New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typesutil: Check support conf.Error #1514

Merged

xushiwei merged 1 commit into goplus:main from xushiwei:typesutil

Nov 2, 2023

Member

xushiwei commented Nov 2, 2023

No description provided.


          typesutil: Check support conf.Error

fa02f3d

xushiwei merged commit 0216d0a into goplus:main

12 checks passed

nighca reviewed

View reviewed changes

x/typesutil/check.go

+              func convErr(fset *token.FileSet, e error) (*types.Error, bool) {
+              	switch v := e.(type) {
+              	case *gox.CodeError:
+              		return &types.Error{Fset: fset, Pos: v.Pos, Msg: v.Msg}, true

nighca Nov 2, 2023

我这里看 types.Error 的 Pos 类型是 token.Pos。而 gox.CodeError 的 Pos 是 *token.Position，这里能直接赋值（Pos: v.Pos）的？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment