no-popups: * true rule issue

[harshanvn]

Describe the issue

Having no-popups: * true rule, and opening a link (through left-click) causes previously opened tab to close itself..

One or more specific URLs where the issue occurs

Sample URL: https://github.com/gorhill/uBlock/issues

Screenshot in which the issue can be seen

N/A

Steps for anyone to reproduce the issue

1. Open/Navigate to https://github.com/gorhill/uBlock/issues in new Window
2. Right-click on any issue and select open link in new tab, for example do it for (Why no "Show ads everywhere except for these domains" option like in Adblock? #2276) issue.
3. At this point, you have 2 tabs opened.
4. Now, on the 1st tab, open any issue by left-click
5. You will see that 2nd tab is closed because of no-popups: * true, which should not be the case.

Your settings

• Browser/version: Chrome v55.0.2883.87 m (64-bit), W10
• uBlock Origin version: 1.10.4

Your filter lists

uBlock Filters + Malware Domains ( Option 1 & 2 ) + Social ( Option 2 ) + Multipurpose ( Option 5 )

Your custom filters (if any)

no-popups: * true ( i have many, i don't think it matters here )

[uBlock-user]

2nd tab is closed

Can't reproduce that. The tab stays open in my case, nothing happens.

[okiehsch]

I can reproduce.

1. Right-click Why no "Show ads everywhere except for these domains" option like in Adblock? #2276
2. Left-click https://gist.github.com
3. Result
   

[gorhill]

I can reproduce. There is a 10-second span within which uBO will keep evaluating whether the popup must be closed or not. When we navigate to a new URL in the source tab, the address of the new tab (the "popup") no longer match the link originally clicked to open the source tab, and uBO sees the new tab (popup) as "untrusted".

Fix for this is not trivial, I need to investigate.

[uBlock-user]

okiehsch, with your steps, I can reproduce.

[gorhill]

Fixed with 7713597.