Redirection issue

[okiehsch]

Describe the issue

The filter

*/content/libs/comscore/comscore.min.js$script,first-party,redirect=noopjs

does not lead to a redirection of the request.

One or more specific URLs where the issue occurs

http://www.whas11.com/article/news/atf-investigating-after-congressional-candidate-cut-apart-ar-15/291-526898428

Steps for anyone to reproduce the issue

• Disable uBO-unbreak

• Go to

http://www.whas11.com/article/news/atf-investigating-after-congressional-candidate-cut-apart-ar-15/291-526898428

the video will not play because of the blocked content/libs/comscore/comscore.min.js request.

• Add */content/libs/comscore/comscore.min.js$script,first-party,redirect=noopjs to your filter list and reload.
  The video will still not play and the logger shows that no redirection has occurred.

• Add */content/libs/comscore/comscore.min.js$script,~third-party,redirect=noopjs to your filter list and reload.
  The video will play and the logger shows a successful redirection.

Your settings

• OS/version: Windos 10
• Browser/version: Chrome 65
• uBlock Origin version: 1.15.2

Your filter lists

Default

[jspenguin2017]

That is weird. With first-party the redirect= directive is discarded because there is no destination domain. Hold on, let me trace it.

[jspenguin2017]

redirect-engine.js has a special case that handles first-party but nothing that handles ~third-party:

[okiehsch]

Yes, to quote gorhill:

The current behavior is how I reworked redirect over time. Originally there had to be a domain option and a hostname part to the filter (||). Eventually I allowed first-party to be used in place of domain. Again later I allowed a redirect directive to not longer be forced to have a hostname. However the parsing needs to be reworked further it seems, I should not discard the directive if first-party is present without a hostname. A redirect directive is really two things at once: a static filter, and a redirect directive. I need to adjust the parser code for this.

[jspenguin2017]

~third-party is ignored, so the second filter would be equivalent to:

*/content/libs/comscore/comscore.min.js$script,redirect=noopjs

Which is probably not intended.

The actual code that handles redirection is probably not aware of request party and needs to be adjusted. The parser is easy to fix (still need to figure out how to flag it as first-party though):

diff --git a/src/js/redirect-engine.js b/src/js/redirect-engine.js
index a7d539c..61ca5bf 100644
--- a/src/js/redirect-engine.js
+++ b/src/js/redirect-engine.js
@@ -318,8 +318,8 @@ RedirectEngine.prototype.compileRuleFromStaticFilter = function(line) {
             srcs = option.slice(7).split('|');
             continue;
         }
-        if ( option === 'first-party' ) {
-            srcs.push(µburi.domainFromHostname(des) || des);
+        if ( option === 'first-party' || option === '~third-party' ) {
+            srcs.push(µburi.domainFromHostname(des) || des || '<flag-first-party>');
             continue;
         }
         // One and only one type must be specified.

[gorhill]

The redirect=/redirect-rule= options should no longer suffer syntax quirks in latest dev build -- the options are now parsed/compiled and enforced in the static network filtering engine. They can also be excepted just the same way we can except csp= and queryprune= filters -- all these filters are considered modifier filters.