New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/chat/client.go: avoid allocating []byte{} for PingMessage #312

Merged

garyburd merged 1 commit into gorilla:master from JordanP:patch-1

Dec 10, 2017

Contributor

JordanP commented Dec 9, 2017

It's useless and only gives more work to the GC.


          examples/chat/client.go: avoid allocating []byte{} for PingMessage

It's useless and only gives more work to the GC.

Contributor

garyburd commented Dec 9, 2017 •

edited

Loading

[]byte{} does not allocate memory. I'll merge because the code is simpler.

garyburd merged commit cdedf21 into gorilla:master

JordanP deleted the patch-1 branch

December 10, 2017 10:05

gorilla locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.