Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(countryselector button props): enables passing through props to … #192

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

ccummings-iddw
Copy link

@ccummings-iddw ccummings-iddw commented Jul 3, 2024

…the country selector button

What has been done

Adds a new prop to the PhoneInput component called countrySelectorButtonProps which allows the developer to pass in relevant props directly to the button element in the CountrySelector component

Checklist before requesting a review

  • I have read the contributing doc before submitting this PR.
  • Commit titles correspond to the convention.
  • I have performed a self-review of my code.
  • Tests for the changes have been added (for bug fixes/features).
  • Docs have been added / updated (for bug fixes / features).

Screenshots (if appropriate):

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-international-phone-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 3:02pm
react-international-phone-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 3:02pm

updates the documentation to include references to the new prop added
@ccummings-iddw
Copy link
Author

ccummings-iddw commented Jul 9, 2024

@goveo Any chance you could take a look at this PR? Or is there a different approach that is already available that has this same functionality?

I want to add this functionality to be able to override fields/html attributes on the button element such as aria-label, id, etc..

@goveo goveo self-requested a review July 9, 2024 19:35
Copy link
Owner

@goveo goveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!
Overall it looks good, but docs updates are missing.

Please add new props to the docs.
Also remove pnpm-lock.yaml change please 🙏

@ccummings-iddw
Copy link
Author

ccummings-iddw commented Aug 9, 2024

@goveo - sorry for the delay. updated to include docs change. I can't seem to remove the pnpm-lock.yaml file changes, I believe its just whitespace changes... can we merge this anyways?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants