-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(countryselector button props): enables passing through props to … #192
base: development
Are you sure you want to change the base?
Conversation
…the country selector button
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
updates the documentation to include references to the new prop added
@goveo Any chance you could take a look at this PR? Or is there a different approach that is already available that has this same functionality? I want to add this functionality to be able to override fields/html attributes on the button element such as aria-label, id, etc.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!!
Overall it looks good, but docs updates are missing.
Please add new props to the docs.
Also remove pnpm-lock.yaml
change please 🙏
@goveo - sorry for the delay. updated to include docs change. I can't seem to remove the pnpm-lock.yaml file changes, I believe its just whitespace changes... can we merge this anyways? |
…the country selector button
What has been done
Adds a new prop to the PhoneInput component called countrySelectorButtonProps which allows the developer to pass in relevant props directly to the button element in the CountrySelector component
Checklist before requesting a review
Screenshots (if appropriate):