Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): Use argument label code action #2126

Merged
merged 1 commit into from
Jul 31, 2024
Merged

feat(lsp): Use argument label code action #2126

merged 1 commit into from
Jul 31, 2024

Conversation

alex-snezhko
Copy link
Member

Screenshot from 2024-07-27 19-24-45

Screenshot from 2024-07-27 19-24-55

Screenshot from 2024-07-27 19-25-12

Screenshot from 2024-07-27 19-25-20

ospencer
ospencer reviewed Jul 28, 2024
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you try to use this action on an argument that already has a label?

@alex-snezhko alex-snezhko force-pushed the alex/explicit-annotate-code-action branch from 4ddd10e to 8a5275c Compare July 29, 2024 04:40
Base automatically changed from alex/explicit-annotate-code-action to main July 29, 2024 06:00
@alex-snezhko
Copy link
Member Author

alex-snezhko commented Jul 30, 2024 •
edited
Loading

@ospencer the code action would only show if there is no label

@alex-snezhko alex-snezhko force-pushed the alex/lsp-use-arg-label-code-action branch from 8620afc to 082756e Compare July 31, 2024 03:18
@ospencer ospencer added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 4399387 Jul 31, 2024
13 checks passed
@ospencer ospencer deleted the alex/lsp-use-arg-label-code-action branch July 31, 2024 19:16
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@phated phated Awaiting requested review from phated phated is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-snezhko @ospencer