chore(stdlib): Optimize List.join
#2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts,
jozanza and
alex-snezhko
as code owners
ospencer
requested changes
Jul 30, 2024
stdlib/list.gr
Outdated
| } | ||
| } | ||
| @unsafe | ||
| let rec iterBuildString = ( |
There was a problem hiding this comment.
Could we call this something like joinHelp or buildJoinedString?
stdlib/list.gr
Outdated
| use DataStructures.{ stringSize } | ||
| match (lst) { | ||
| [] => void, | ||
| // Last Element |
There was a problem hiding this comment.
Suggested change
| // Last Element | |
| // Last element |
stdlib/list.gr
Outdated
| let size = stringSize(ptr) | ||
| Memory.copy(offset, ptr + 8n, size) | ||
| }, | ||
| // Regular Path |
There was a problem hiding this comment.
Suggested change
| // Regular Path |
stdlib/list.gr
Outdated
| Memory.copy(offset, ptr + 8n, size) | ||
| let offset = offset + size | ||
| Memory.copy(offset, sepPtr, sepSize) | ||
| iterBuildString(strPtr, sepPtr, sepSize, offset + sepSize, tl) |
There was a problem hiding this comment.
Suggested change
| iterBuildString(strPtr, sepPtr, sepSize, offset + sepSize, tl) | |
| iterBuildString(strPtr, sepPtr, sepSize, offset + sepSize, tl) | |
| ignore(hd) |
There was a problem hiding this comment.
I should put the ignore above the function call right otherwise it wont be a tail call?
stdlib/list.gr
Outdated
| use DataStructures.{ allocateString, stringSize } | ||
| let sepPtr = WasmI32.fromGrain(separator) | ||
| let sepSize = stringSize(sepPtr) | ||
| let strSize = iterSize(sepSize, 0n - sepSize, list) |
There was a problem hiding this comment.
With the changes I suggested this would just be 0n.
stdlib/list.gr
Outdated
| let sepPtr = WasmI32.fromGrain(separator) | ||
| let sepSize = stringSize(sepPtr) | ||
| let strSize = iterSize(sepSize, 0n - sepSize, list) | ||
| if (strSize <= 0n) return "" |
There was a problem hiding this comment.
And this check wouldn't be needed.
|
Those changes have been commited. |
ospencer
reviewed
Aug 4, 2024
ospencer
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr optimizes
List.joinsimilarly to howArray.joinwas optimized in #1948, this change makesList.joinuse only a single allocation, and should reduce the number of times we need to copy while reallocating.Closes: #728