Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph enhancements #359

Closed
reox opened this issue May 7, 2022 · 6 comments
Closed

Graph enhancements #359

reox opened this issue May 7, 2022 · 6 comments
Assignees

Comments

@reox
Copy link
Contributor

reox commented May 7, 2022

The weight/flow graph has changed in version 6 and in my opinion, a few things have changed to be not as nice as they were before:

  • the flow is now fixed to 10ml/s, the weight is fixed at 100ml - both are too much for espresso. I can barely see the weight change :(
  • The graph now starts on the right side and slides to the left
  • only a window of 30s is visible
  • in the (very very nice!) landscape view, the x-axis ticks are not shown (at least for me... I'm using a Samsung S9 with Android 10)

Portrait:
image

Landscape:
image

My enhancements for the graph would be:

  • Start on the left at 0.0s. Generally the start right, slide left is OK but personally I like it more if the graph starts on the left side and advances over the graph area
  • maybe show a window of 45s or more or start compressing the x-axis instead of using a window
    • a more sophisticated version could be to show the last 20s or so and compress the rest into a smaller area
  • bring back auto scale for weight and flow, and maybe start at "reasonable" limits depending on the preparation type (e.g. 0..2ml/s + 0..50ml for espresso; 0..10ml/s + 0..250ml for v60)
    • Interestingly, if you open up the brew later, the graph looks really nice!
  • better distinguish the primary and secondary y-axis, for example by showing the units or the colors directly over the axis ticks

Yet another nice touch would be vertical lines indicating the times for pre-infusion/blooming end and first drop.

But these are just some ideas, maybe someone can come up with even a better idea :)

@graphefruit
Copy link
Owner

Good Morning @reox,
sorry for the late reply.
The new graph was added, because the old one was jumpy, and on a longer brew time realy nested and hard to read.

Start from the left:
For streaming left to right i've made an ticket here: nagix/chartjs-plugin-streaming#162

Compression or something like this is not that supported with this plugin.
If you find any other plugins which may be handle this solution better, and is performant and not junky, please let me know.
Maybe we can go up to 45s on the frame, I didn't try it out, its rather that the first lines will appear later, as far as I know, which would be to late for pressure profiling or something else.

Autoscale:
The Graph is autoscaling, but after I've set the first initial marks it doesn't look like.
I've made two different initials for espresso and filter, I gonna have a look at them and fit them better.

If you open the graph later one, the normal chartjs plugin is used, and not the streaming one.

Difference of primary and secondary y-axis:
Its possible to show the ticks over the line with tooltips but you'll come into the issue that every 10hz a new value is written, this would explode the chart.
I don't know if the different axis can be colored, would need to have a look.

Pre-Infuion/Blooming line:
Would be possible, but users would need to press the timing button manually, this won't be anything automatic calculated.

Landscape mode:
I gonna have a look where the Axis's wents.

The graph changes for this version, where already where hard to integrate, so I'm happy for every helping hand here.

@reox
Copy link
Contributor Author

reox commented May 11, 2022

The graph changes for this version, where already where hard to integrate, so I'm happy for every helping hand here.

no worries, the new graph is already very nice - especially that you can see now the flow better! If there are technical limitations, you can not do much - that is clear.
Unfortunately, all I can do to help is to tell you my user experience 😅

@graphefruit
Copy link
Owner

Hey @reox,
I've made smaller fixes, specially defined the range for espresso, please have a look

@reox
Copy link
Contributor Author

reox commented May 21, 2022

Yes that look already better from the ranges! But with the realtime flow, it looks even more cluttered IMHO 😅
Especially, if all lines are over each other like in this example:
image

@graphefruit
Copy link
Owner

In the next version there will be the possibility to hide the different graphs for filter/espresso modes so there should be less clutter

graphefruit added a commit that referenced this issue Oct 21, 2022
#404 - closed because of fix
#370 - Error information if bean was not approved yet
#368 - Displays brews for bean
#365 - Popsicle & pressure graph supported
#359 - Some graph enhancements
graphefruit added a commit that referenced this issue Oct 29, 2022
#404 - closed because of fix
#370 - Error information if bean was not approved yet
#368 - Displays brews for bean
#365 - Popsicle & pressure graph supported
#359 - Some graph enhancements
@graphefruit graphefruit self-assigned this Jun 15, 2023
@graphefruit
Copy link
Owner

In the next version, the graph will also be set to the whole range when pausing, also when going to edit, the whole graph will be displayed directly.
I'll close this ticket, as so many things has been fixed and changed, if there are any new wishes, please open up a new ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants