Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incremental: introduce GraphQLWrappedResult to avoid filtering #4026

Merged
merged 27 commits into from
Apr 18, 2024
Merged

incremental: introduce GraphQLWrappedResult to avoid filtering #4026

merged 27 commits into from
Apr 18, 2024
+1,207 −1,221

Commits on Apr 8, 2024

  1. incremental: introduce GraphQLResult type to avoid filtering

    @yaacovCR
    yaacovCR committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b97128f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. remove unnecessary members from incrementalContext 

    turns out we just need errors!
    @yaacovCR
    yaacovCR committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    bd52975 View commit details
    Browse the repository at this point in the history

  2. add comment explaining strategy for when we add an extra tick

    @yaacovCR
    yaacovCR committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    25af8dc View commit details
    Browse the repository at this point in the history

  3. add comment

    @yaacovCR
    yaacovCR committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    056c344 View commit details
    Browse the repository at this point in the history

  4. drop check for simpllicity

    @yaacovCR
    yaacovCR committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1105ee1 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. remove last traces of IncrementalContext

    @yaacovCR
    yaacovCR committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    6cfd1f0 View commit details
    Browse the repository at this point in the history

  2. simplify stream handling

    @yaacovCR
    yaacovCR committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    3edba1a View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. remove unnecessary type

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b39435a View commit details
    Browse the repository at this point in the history

  2. refactor classes into interfaces

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    537ce5f View commit details
    Browse the repository at this point in the history

  3. change logic to reduce extra ticks

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    26f089d View commit details
    Browse the repository at this point in the history

  4. use errors as discriminator rather than null

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0202ba6 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary exports

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    facaf19 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary guard

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    26974f4 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary loop

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    47b988c View commit details
    Browse the repository at this point in the history

  8. rename fragmentResult

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    679aeb3 View commit details
    Browse the repository at this point in the history

  9. add better typing for CancellableStreamRecord

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1b83ea5 View commit details
    Browse the repository at this point in the history

  10. introduce small helper

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7dcb8b3 View commit details
    Browse the repository at this point in the history

  11. fix strict types

    @yaacovCR
    yaacovCR committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0b9842c View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. rename NonTerminatingStreamItemsResult to ReconcilableStreamItemsResult

    @yaacovCR
    yaacovCR committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7511630 View commit details
    Browse the repository at this point in the history

  2. break synchronous loop early on non-reconcilable result

    @yaacovCR
    yaacovCR committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    765860e View commit details
    Browse the repository at this point in the history

  3. just push!

    @yaacovCR
    yaacovCR committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    74d092e View commit details
    Browse the repository at this point in the history

  4. rename GraphQLResult to GraphQLWrappedResult

    @yaacovCR
    yaacovCR committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    24136af View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. pass arguments instead of executor function

    @yaacovCR
    yaacovCR committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    eb435a0 View commit details
    Browse the repository at this point in the history

  2. remove extra tick

    @yaacovCR
    yaacovCR committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f917255 View commit details
    Browse the repository at this point in the history

  3. remove another extra tick

    @yaacovCR
    yaacovCR committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8ffb37f View commit details
    Browse the repository at this point in the history

  4. remove extra function

    @yaacovCR
    yaacovCR committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c22cd01 View commit details
    Browse the repository at this point in the history

  5. add comment regarding stream terminators

    @yaacovCR
    yaacovCR committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6e44e3a View commit details
    Browse the repository at this point in the history