Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative spec implementation of deduplicated incremental delivery #1077

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
+451 −70
Draft

Alternative spec implementation of deduplicated incremental delivery #1077

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
160315d
Extract common logic from ExecuteQuery, ExecuteMutation and ExecuteSu…
benjie Apr 28, 2023
c5c33a0
Change ExecuteSelectionSet to ExecuteGroupedFieldSet
benjie Apr 28, 2023
3488636
Correct reference to MergeSelectionSets
benjie Aug 21, 2023
0ffed63
moves Field Collection section earlier
yaacovCR Feb 15, 2024
ffbfd3c
Introduce `@defer` directive
yaacovCR Feb 15, 2024
5ce10a5
refactor a few lines out of YieldSubsequentResults
yaacovCR Jun 13, 2024
b9a2500
add a word or two about which child nodes are being promoted
yaacovCR Jun 18, 2024
c7d5ccd
be more graphy
yaacovCR Jun 18, 2024
bfe47f3
fix timing
yaacovCR Jun 19, 2024
587589c
reuse function
yaacovCR Jun 19, 2024
e8368ed
fix
yaacovCR Jun 19, 2024
7d8b9d0
rename BuildGraph to GraphFromRecords
yaacovCR Jun 19, 2024
a4b506c
reword recursive abort case
yaacovCR Jun 19, 2024
c796f03
bring BuildFieldPlan in line with implementation
yaacovCR Jul 17, 2024
f0ebc12
rename "deferred grouped field set record" to "execution group"
yaacovCR Jul 17, 2024
4b86250
rename ExecuteExecutionGroup to CollectExecutionGroup
yaacovCR Jul 17, 2024
db54ad8
properly initialize deferUsages with their parents
yaacovCR Jul 18, 2024
a2516e2
move Field Collection back to where it was
yaacovCR Jul 18, 2024
4b19cf5
f
yaacovCR Jul 18, 2024
313aaa6
use fieldDetailsList consistently
yaacovCR Jul 18, 2024
4571da9
add info re: data structures
yaacovCR Jul 18, 2024
3556851
rename FieldPlan to ExecutionPlan
yaacovCR Jul 20, 2024
a950a96
path => label
yaacovCR Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/Section 5 -- Validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ unambiguous. Therefore any two field selections which might both be encountered
for the same object are only valid if they are equivalent.

During execution, the simultaneous execution of fields with the same response
name is accomplished by {MergeSelectionSets()} and {CollectFields()}.
name is accomplished by {CollectSubfields()}.

For simple hand-written GraphQL, this rule is obviously a clear developer error,
however nested fragments can make this difficult to detect manually.
Expand Down
Loading
Loading