fix(cart): magento driver resolution fails for no discounts (#2638)

graycoreio · Dec 1, 2023 · 1ea70a1 · 1ea70a1
1 parent bd968f7
commit 1ea70a1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/libs/cart/driver/magento/src/models/responses/cart.ts b/libs/cart/driver/magento/src/models/responses/cart.ts
@@ -27,7 +27,7 @@ export interface MagentoCart {
       amount: MagentoMoney;
       label: string;
     }[];
-    discounts: {
+    discounts?: {
       amount: MagentoMoney;
       label: string;
     }[];

diff --git a/libs/cart/driver/magento/src/transforms/outputs/cart-totals-transformer.spec.ts b/libs/cart/driver/magento/src/transforms/outputs/cart-totals-transformer.spec.ts
@@ -88,4 +88,16 @@ describe('transformCartTotals', () => {
     expect(transformedTotals[DaffCartTotalTypeEnum.tax].value).toEqual(0);
     expect(transformedTotals[DaffCartTotalTypeEnum.shipping].value).toEqual(null);
   });
+
+  describe('when discounts is null', () => {
+    beforeEach(() => {
+      stubMagentoCart.prices.discounts = null;
+    });
+
+    it('should set discount value to 0', () => {
+      const transformedTotals = transformCartTotals(stubMagentoCart).totals;
+
+      expect(transformedTotals[DaffCartTotalTypeEnum.discount].value).toEqual(0);
+    });
+  });
 });
diff --git a/libs/cart/driver/magento/src/transforms/outputs/cart-totals-transformer.ts b/libs/cart/driver/magento/src/transforms/outputs/cart-totals-transformer.ts
@@ -55,7 +55,7 @@ export function transformCartTotals(cart: Partial<MagentoCart>): {totals: DaffCa
       [DaffCartTotalTypeEnum.discount]: {
         name: DaffCartTotalTypeEnum.discount,
         label: 'Discounts',
-        value: daffAdd(...cart.prices.discounts.map((discount) => discount.amount.value)),
+        value: cart.prices.discounts ? daffAdd(...cart.prices.discounts.map((discount) => discount.amount.value)) : 0,
         order: 6,
       },
       [DaffCartTotalTypeEnum.shipping]: {