Skip to content

Commit

Permalink
chore(all): fix faker deprecations (#2803)
Browse files Browse the repository at this point in the history
  • Loading branch information
griest024 committed May 21, 2024
1 parent 6ee0c82 commit 24ca71c
Show file tree
Hide file tree
Showing 13 changed files with 28 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import { MagentoCartAddressInput } from '@daffodil/cart/driver/magento';
import { DaffModelFactory } from '@daffodil/core/testing';

export class MockMagentoCartAddressInput implements MagentoCartAddressInput {
region_id = faker.unique(faker.datatype.number);
region_id = faker.helpers.unique(faker.datatype.number);
country_code = faker.address.countryCode();
street = [faker.address.streetAddress()];
company = faker.company.companyName();
telephone = faker.phone.phoneNumber();
company = faker.company.name();
telephone = faker.phone.number();
postcode = faker.address.zipCode();
city = faker.address.city();
firstname = faker.name.firstName();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ import { DaffModelFactory } from '@daffodil/core/testing';

export class MockMagentoCartAddress implements MagentoCartAddress {
__typename = 'BillingCartAddress';
customer_address_id = faker.unique(faker.datatype.number);
customer_address_id = faker.helpers.unique(faker.datatype.number);
region = {
__typename: 'CartAddressRegion',
region_id: faker.unique(faker.datatype.number),
region_id: faker.helpers.unique(faker.datatype.number),
code: faker.address.stateAbbr(),
};
country = {
Expand All @@ -18,8 +18,8 @@ export class MockMagentoCartAddress implements MagentoCartAddress {
label: faker.address.country(),
};
street = [faker.address.streetAddress()];
company = faker.company.companyName();
telephone = faker.phone.phoneNumber();
company = faker.company.name();
telephone = faker.phone.number();
postcode = faker.address.zipCode();
city = faker.address.city();
firstname = faker.name.firstName();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ export class MockMagentoBundleCartItem extends MockMagentoCartItem implements Ma
__typename = MagentoCartItemTypeEnum.Bundle;
bundle_options = [
{
id: faker.unique(faker.datatype.number),
id: faker.helpers.unique(faker.datatype.number),
type: 'radio',
label: faker.random.word(),
price: faker.datatype.number({ min: 1, max: 99 }),
quantity: 1,
values: [{
id: faker.unique(faker.datatype.number),
id: faker.helpers.unique(faker.datatype.number),
label: faker.random.word(),
price: faker.datatype.number({ min: 1, max: 99 }),
quantity: 1,
Expand Down
2 changes: 1 addition & 1 deletion libs/checkout/testing/src/order/factories/order.factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { DaffModelFactory } from '@daffodil/core/testing';
* @deprecated
*/
export class MockOrder implements DaffOrder {
id = faker.unique(faker.datatype.number);
id = faker.helpers.unique(faker.datatype.number);
created_at = new Date();
updated_at = new Date();
store_to_base_rate = faker.datatype.number({ min: 1, max: 1000 });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { DaffModelFactory } from '@daffodil/core/testing';

export class MockShippingOption implements ShippingOption {
id = faker.datatype.uuid();
text = faker.company.companyName() + ' ' + faker.commerce.productAdjective() + ' Shipping';
text = faker.company.name() + ' ' + faker.commerce.productAdjective() + ' Shipping';
}

@Injectable({
Expand Down
4 changes: 2 additions & 2 deletions libs/core/testing/src/factories/address.factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ import { DaffModelFactory } from './factory';
export class MockDaffAddress implements DaffAddress {
firstname = faker.name.firstName();
lastname = faker.name.lastName();
street = faker.address.streetName();
street = faker.address.street();
city = faker.address.city();
state = faker.address.stateAbbr();
email = faker.internet.email();
postcode = faker.address.zipCode();
telephone = faker.phone.phoneNumber();
telephone = faker.phone.number();
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class MockMagentoTokenBaseCard implements MagentoTokenBaseCard {
hash = faker.datatype.uuid();
address = this.addressFactory.create();
customer_email = faker.internet.email();
customer_id = faker.unique(faker.datatype.number);
customer_id = faker.helpers.unique(faker.datatype.number);
method = faker.random.word();
active = faker.datatype.boolean();
created_at = faker.date.past().toString();
Expand All @@ -23,7 +23,7 @@ export class MockMagentoTokenBaseCard implements MagentoTokenBaseCard {
label = faker.random.word();
additional = {
cc_type: faker.helpers.arrayElement(Object.values(MagentoTokenBaseCardTypeCode)),
cc_owner: faker.name.findName(),
cc_owner: faker.name.fullName(),
cc_last4: faker.finance.creditCardNumber().slice(4),
cc_exp_year: faker.date.future().getMonth().toString(),
cc_exp_month: faker.date.future().getFullYear().toString(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class MockDaffCustomerPaymentRequest extends MockPaymentRequest implement
address = this.addressFactory.create();
default = faker.datatype.boolean();
nickname = faker.random.word();
owner = faker.name.findName();
owner = faker.name.fullName();

constructor(
private addressFactory: DaffCustomerAddressFactory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class MockDaffCustomerPayment extends MockPaymentResponse implements Daff
default = faker.datatype.boolean();
nickname = faker.random.word();
createdAt = faker.date.recent().toISOString();
owner = faker.name.findName();
owner = faker.name.fullName();

constructor(
private addressFactory: DaffCustomerAddressFactory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ import { MagentoCustomerAddress } from '@daffodil/customer/driver/magento';

export class MockMagentoCustomerAddress implements MagentoCustomerAddress {
__typename = 'CustomerAddress';
id = faker.unique(faker.datatype.number);
id = faker.helpers.unique(faker.datatype.number);
region = {
__typename: 'CustomerAddressRegion',
region_code: faker.address.stateAbbr(),
region_id: faker.unique(faker.datatype.number),
region_id: faker.helpers.unique(faker.datatype.number),
};
country_code = faker.address.countryCode();
street = [faker.address.streetAddress()];
company = faker.company.companyName();
telephone = faker.phone.phoneNumber();
company = faker.company.name();
telephone = faker.phone.number();
postcode = faker.address.zipCode();
city = faker.address.city();
firstname = faker.name.firstName();
Expand Down
2 changes: 1 addition & 1 deletion libs/geography/testing/src/factories/address.factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { DaffAddress } from '@daffodil/geography';


export class MockDaffAddress implements DaffAddress {
street = faker.address.streetName();
street = faker.address.street();
street2 = faker.address.secondaryAddress();
city = faker.address.city();
region = faker.datatype.uuid();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class MockDaffPersonalAddress extends MockDaffAddress implements DaffPers
middlename = faker.name.firstName();
lastname = faker.name.lastName();
email = faker.internet.email();
telephone = faker.phone.phoneNumber();
telephone = faker.phone.number();
}

@Injectable({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { MagentoOrderAddress } from '@daffodil/order/driver/magento/2-4-1';

export class MockOrderAddress implements MagentoOrderAddress {
__typename = <const>'OrderAddress';
street = [faker.address.streetName()];
street = [faker.address.street()];
city = faker.address.city();
region_id = faker.unique(faker.datatype.number);
region_id = faker.helpers.unique(faker.datatype.number);
region_code = faker.address.stateAbbr();
postcode = faker.address.zipCode();
country = faker.address.countryCode();
Expand All @@ -18,9 +18,9 @@ export class MockOrderAddress implements MagentoOrderAddress {
firstname = faker.name.firstName();
middlename = faker.name.firstName();
lastname = faker.name.lastName();
telephone = faker.phone.phoneNumber();
fax = faker.phone.phoneNumber();
company = faker.company.companyName();
telephone = faker.phone.number();
fax = faker.phone.number();
company = faker.company.name();
}

@Injectable({
Expand Down

0 comments on commit 24ca71c

Please sign in to comment.