feat(authorizenet): only dispatch success when accept.js actually loa…

…ds (#2436)
graycoreio · May 11, 2023 · 37e0548 · 37e0548
1 parent 24272f9
commit 37e0548
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/libs/authorizenet/state/src/effects/authorize-net.effects.spec.ts b/libs/authorizenet/state/src/effects/authorize-net.effects.spec.ts
@@ -23,6 +23,7 @@ import {
   DaffAuthorizeNetConfig,
   DaffAuthorizeNetDriver,
   DaffAuthorizeNetPaymentId,
+  DaffAuthorizeNetAcceptjsMissingError,
 } from '@daffodil/authorizenet/driver';
 import { MAGENTO_AUTHORIZE_NET_PAYMENT_ID } from '@daffodil/authorizenet/driver/magento';
 import { DaffTestingAuthorizeNetDriverModule } from '@daffodil/authorizenet/driver/testing';
@@ -220,5 +221,14 @@ describe('DaffAuthorizeNetEffects', () => {
 
       expect(effects.loadAcceptJs$(0, 0)).toBeObservable(expected);
     });
+
+    it('should trigger a DaffLoadAcceptJsFailure action if acceptJs fails to load but does not throw an error', () => {
+      acceptJsLoadingServiceSpy.getAccept.and.returnValue(null);
+      const loadAcceptJsAction = new DaffLoadAcceptJs();
+      actions$ = hot('--a', { a: loadAcceptJsAction });
+      const expected = cold('--b', { b: new DaffLoadAcceptJsFailure(<any>jasmine.any(DaffAuthorizeNetAcceptjsMissingError)) });
+
+      expect(effects.loadAcceptJs$(0, 0)).toBeObservable(expected);
+    });
   });
 });
diff --git a/libs/authorizenet/state/src/effects/authorize-net.effects.ts b/libs/authorizenet/state/src/effects/authorize-net.effects.ts
@@ -28,6 +28,7 @@ import {
   DaffAuthorizeNetDriver,
   DaffAuthorizeNetService,
   DaffAuthorizeNetPaymentId,
+  DaffAuthorizeNetAcceptjsMissingError,
 } from '@daffodil/authorizenet/driver';
 import {
   DaffCartPaymentActionTypes,
@@ -109,7 +110,7 @@ export class DaffAuthorizeNetEffects<T extends DaffAuthorizeNetTokenRequest = Da
     tap((action: DaffLoadAcceptJs) => this.acceptJsLoadingService.load()),
     switchMap(() => defer(() => of(this.acceptJsLoadingService.getAccept())).pipe(
       backoff(maxTries, ms),
-      map(() => new DaffLoadAcceptJsSuccess()),
+      map((Accept) => Accept ? new DaffLoadAcceptJsSuccess() : new DaffLoadAcceptJsFailure(new DaffAuthorizeNetAcceptjsMissingError('Accept.js failed to load.'))),
       catchError((error: DaffError) => of(new DaffLoadAcceptJsFailure(this.errorMatcher(error)))),
     )),
   ));