feat(customer): correctly handle missing customer address ID (#2515)

yes this can really happen

libs/customer/driver/magento/src/models/responses/customer-address.type.ts

@@ -1,18 +1,18 @@
 export interface MagentoCustomerAddress {
-  id: number;
+  id?: number;
   region: {
     region_code: string;
     region_id: number;
   };
-  country_code: string;
-  street: string[];
-  company: string;
-  telephone: string;
-  postcode: string;
-  city: string;
-  firstname: string;
-  lastname: string;
-  email: string;
-  default_billing: boolean;
-  default_shipping: boolean;
+  country_code?: string;
+  street?: string[];
+  company?: string;
+  telephone?: string;
+  postcode?: string;
+  city?: string;
+  firstname?: string;
+  lastname?: string;
+  email?: string;
+  default_billing?: boolean;
+  default_shipping?: boolean;
 }

libs/customer/driver/magento/src/transforms/responses/customer-address.spec.ts

@@ -36,4 +36,17 @@ describe('@daffodil/customer/driver/magento | magentoCustomerAddressTransform',
     expect(result.defaultBilling).toEqual(mockAddress.default_billing);
     expect(result.defaultShipping).toEqual(mockAddress.default_shipping);
   });
+
+  describe('when the ID is null', () => {
+    beforeEach(() => {
+      mockAddress = addressFactory.create({
+        id: null,
+      });
+      result = magentoCustomerAddressTransform(mockAddress);
+    });
+
+    it('should set ID to null', () => {
+      expect(result.id).toBeNull();
+    });
+  });
 });

libs/customer/driver/magento/src/transforms/responses/customer-address.ts

@@ -3,7 +3,7 @@ import { DaffCustomerAddress } from '@daffodil/customer';
 import { MagentoCustomerAddress } from '../../models/public_api';
 
 export const magentoCustomerAddressTransform = (address: MagentoCustomerAddress): DaffCustomerAddress => ({
-  id: String(address.id),
+  id: address.id ? String(address.id) : null,
   street: address.street[0],
   street2: address.street[1],
   city: address.city,