Skip to content

Commit

Permalink
chore!: upgrade node to v18 (#2732)
Browse files Browse the repository at this point in the history
  • Loading branch information
griest024 committed Jan 22, 2024
1 parent cfc2802 commit 4d7498f
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16
FROM node:18

LABEL name="Angular dev environment" \
description="This image can be used to create a dev environment for building Angular apps." \
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.x]
node: [18.19.x]
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
fetch-depth: 0
- uses: graycoreio/github-actions/setup-node@main
with:
node-version: '16.x'
node-version: '18.19.x'
use-stamp-cache: true
- uses: nrwl/nx-set-shas@v3
name: Derive appropriate SHAs for base and head for `nx affected` commands
Expand All @@ -86,7 +86,7 @@ jobs:
fail-fast: false
matrix:
package: ${{ fromJSON(needs.compute_packages.outputs.packages) }}
node: [16.x]
node: [18.19.x]
needs:
- compute_packages
- build
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
VERCEL_ORG: ${{ secrets.VERCEL_ORG }}
with:
artifact: daffio-16.x
artifact: daffio-18.19.x
artifact-zip-name: daffio.zip

publish:
Expand All @@ -147,11 +147,11 @@ jobs:
with:
fail-on-cache-miss: true
path: .nx_cache
key: build-16.x-${{ github.sha }}
key: build-18.19.x-${{ github.sha }}

- uses: graycoreio/github-actions/setup-node@main
with:
node-version: 16.x
node-version: 18.19.x
use-stamp-cache: true
registry-url: 'https://registry.npmjs.org'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- uses: graycoreio/github-actions/angular-universal-vercel-wflw-run@main
id: vercel
with:
artifact: daffio-16.x
artifact: daffio-18.x
artifact-zip-name: daffio.zip
vercel-token: ${{ secrets.VERCEL_TOKEN }}
vercel-org: ${{ secrets.VERCEL_ORG }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16.x]
node: [18.19.x]
steps:
- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.16.0
18.19
36 changes: 27 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@types/gulp": "^4.0.17",
"@types/jasmine": "~3.6.0",
"@types/jasminewd2": "~2.0.8",
"@types/node": "^16.18.68",
"@types/node": "^18.19.8",
"@types/rimraf": "^2.0.5",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",
Expand Down

0 comments on commit 4d7498f

Please sign in to comment.