feat(cart): handle create errors in Magento driver (#2536)

graycoreio · Aug 10, 2023 · 4ead116 · 4ead116
1 parent cffee10
commit 4ead116
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/libs/cart/driver/magento/src/cart.service.spec.ts b/libs/cart/driver/magento/src/cart.service.spec.ts
@@ -279,6 +279,34 @@ describe('@daffodil/cart/driver/magento | DaffMagentoCartService', () => {
   });
 
   describe('create | creates the cart', () => {
+    describe('when there are graphQL errors', () => {
+      it('should throw the error', done => {
+        service.create().pipe(
+          catchError((err) => {
+            expect(err).toEqual(jasmine.any(DaffCartNotFoundError));
+            done();
+            return of();
+          }),
+        ).subscribe(result => {
+          fail('create should throw, not emit');
+        });
+
+        const op = controller.expectOne(addTypenameToDocument(createCart));
+
+        op.flush({
+          errors: [new GraphQLError(
+            'Can\'t find a cart with that ID.',
+            null,
+            null,
+            null,
+            null,
+            null,
+            { category: 'graphql-no-such-entity' },
+          )],
+        });
+      });
+    });
+
     it('should return an observable with the cart ID', done => {
       service.create().subscribe(result => {
         expect(result.id).toEqual(cartId);

diff --git a/libs/cart/driver/magento/src/cart.service.ts b/libs/cart/driver/magento/src/cart.service.ts
@@ -105,6 +105,7 @@ export class DaffMagentoCartService implements DaffCartServiceInterface<DaffCart
   create(): Observable<{id: DaffCart['id']}> {
     return this.mutationQueue.mutate<MagentoCreateCartResponse>({ mutation: createCart }).pipe(
       map(result => ({ id: result.data.createEmptyCart })),
+      catchError(err => throwError(() => transformCartMagentoError(err))),
     );
   }