Skip to content

Commit

Permalink
feat(list)!: shard list component (#2678)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: `DaffListModule` has moved to its own package. Update imports to `@daffodil/design/list`
  • Loading branch information
xelaint committed Dec 20, 2023
1 parent 43edf2d commit 6d96924
Show file tree
Hide file tree
Showing 25 changed files with 30 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';

import { DaffListModule } from '@daffodil/design';
import { DaffCalloutModule } from '@daffodil/design/callout';
import { DaffContainerModule } from '@daffodil/design/container';
import { DaffListModule } from '@daffodil/design/list';

import { DaffioWhyPwaSolutionComponent } from './why-pwa-solution.component';
import { DaffioFeatureComparisonModule } from '../feature-comparison/feature-comparison.module';
Expand Down
2 changes: 1 addition & 1 deletion apps/daffio/src/app/core/footer/footer.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ import {
DaffCopyrightModule,
} from '@daffodil/branding';
import {
DaffListModule,
DaffButtonSetModule,
DaffInputModule,
} from '@daffodil/design';
import { DaffButtonModule } from '@daffodil/design/button';
import { DaffCalloutModule } from '@daffodil/design/callout';
import { DaffContainerModule } from '@daffodil/design/container';
import { DaffListModule } from '@daffodil/design/list';

import { DaffioSimpleFooterComponent } from './simple-footer/simple-footer.component';
import { DaffioSubFooterComponent } from './sub-footer/sub-footer.component';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';

import { DaffListModule } from '@daffodil/design';
import { DaffAccordionModule } from '@daffodil/design/accordion';
import { DaffLinkSetModule } from '@daffodil/design/link-set';
import { DaffListModule } from '@daffodil/design/list';

import { DaffioDocsTableOfContentsComponent } from './table-of-contents.component';

Expand Down
6 changes: 2 additions & 4 deletions apps/demo/src/app/core/footer/footer.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ import { By } from '@angular/platform-browser';
import { RouterTestingModule } from '@angular/router/testing';
import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';

import {
DaffListModule,
DaffButtonSetModule,
} from '@daffodil/design';
import { DaffButtonSetModule } from '@daffodil/design';
import { DaffContainerModule } from '@daffodil/design/container';
import { DaffListModule } from '@daffodil/design/list';

import { FooterComponent } from './footer.component';

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/core/footer/footer.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';

import { DaffListModule } from '@daffodil/design';
import { DaffButtonModule } from '@daffodil/design/button';
import { DaffContainerModule } from '@daffodil/design/container';
import { DaffListModule } from '@daffodil/design/list';

import { FooterComponent } from './footer.component';

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';

import { DaffListModule } from '@daffodil/design';
import { DaffListModule } from '@daffodil/design/list';

import { BasicListComponent } from './basic-list.component';


@NgModule({
declarations: [
BasicListComponent,
Expand Down
3 changes: 1 addition & 2 deletions libs/design/list/examples/src/icon-list/icon-list.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';

import { DaffListModule } from '@daffodil/design';
import { DaffListModule } from '@daffodil/design/list';

import { IconListComponent } from './icon-list.component';


@NgModule({
declarations: [
IconListComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';

import { DaffListModule } from '@daffodil/design';
import { DaffListModule } from '@daffodil/design/list';

import { MultilineListComponent } from './multiline-list.component';


@NgModule({
declarations: [
MultilineListComponent,
Expand Down
3 changes: 1 addition & 2 deletions libs/design/list/examples/src/nav-list/nav-list.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';

import { DaffListModule } from '@daffodil/design';
import { DaffListModule } from '@daffodil/design/list';

import { NavListComponent } from './nav-list.component';


@NgModule({
declarations: [
NavListComponent,
Expand Down
9 changes: 9 additions & 0 deletions libs/design/list/ng-package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"$schema": "../../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../dist/design/list",
"deleteDestPath": false,
"lib": {
"entryFile": "src/index.ts",
"styleIncludePaths": ["../src/scss"]
}
}
1 change: 1 addition & 0 deletions libs/design/list/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './public_api';
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
import {
DaffPrefixDirective,
DaffSuffixDirective,
} from '../../../core/prefix-suffix/public_api';
} from '@daffodil/design';

@Component({
selector:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use 'sass:map';
@use '../../../../scss/core';
@use '../../../../scss/theming';
@use '../../scss/core';
@use '../../scss/theming';

@mixin daff-list-theme($theme) {
$gray: core.daff-map-deep-get($theme, 'core.gray');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';

import { DaffPrefixSuffixModule } from '@daffodil/design';

import { DaffListComponent } from './list/list.component';
import { DaffListItemComponent } from './list-item/list-item.component';
import { DaffListSubheaderDirective } from './list-subheader/list-subheader.directive';
import { DaffPrefixSuffixModule } from '../../core/prefix-suffix/prefix-suffix.module';

@NgModule({
imports: [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '../../../../scss/typography' as t;
@use '../../../../scss/interactions';
@use '../../../../scss/layout';
@use '../../../scss/typography' as t;
@use '../../../scss/interactions';
@use '../../../scss/layout';

@mixin daff-list() {
$root: &;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
Renderer2,
} from '@angular/core';

import { daffArticleEncapsulatedMixin } from '../../../core/article-encapsulated/public_api';
import { daffArticleEncapsulatedMixin } from '@daffodil/design';

/**
* @deprecated
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion libs/design/scss/theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
@use '../callout/src/callout-theme' as callout;
@use '../card/src/card-theme' as card;
@use '../hero/src/hero-theme' as hero;
@use '../src/molecules/list/list/list-theme' as list;
@use '../list/src/list-theme' as list;
@use '../src/molecules/media-gallery/media-gallery-theme' as media-gallery;
@use '../src/molecules/menu/menu-theme' as menu;
@use '../src/molecules/modal/modal-theme' as modal;
Expand Down
1 change: 0 additions & 1 deletion libs/design/src/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export * from './molecules/backdrop/public_api';
export * from './molecules/button-set/public_api';
export * from './molecules/image-gallery/public_api';
export * from './molecules/image-list/public_api';
export * from './molecules/list/public_api';
export * from './molecules/media-gallery/public_api';
export * from './molecules/menu/public_api';
export * from './molecules/modal/public_api';
Expand Down

0 comments on commit 6d96924

Please sign in to comment.