Skip to content

Commit

Permalink
feat(design)!: remove deprecatedDaffProgressIndicatorComponent from…
Browse files Browse the repository at this point in the history
… `@daffodil/design` (#2862)

BREAKING CHANGE: `DaffProgressIndicatorComponent` has been removed from `@daffodil/design`. Use the `DaffProgressBarComponent` instead.
  • Loading branch information
xelaint committed Jun 14, 2024
1 parent 26f13a5 commit 87e6d41
Show file tree
Hide file tree
Showing 22 changed files with 6 additions and 407 deletions.
3 changes: 0 additions & 3 deletions apps/demo/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import { EffectsModule } from '@ngrx/effects';
import { StoreModule } from '@ngrx/store';
import { StoreDevtoolsModule } from '@ngrx/store-devtools';

import { DaffProgressIndicatorModule } from '@daffodil/design';

import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { DemoCartRootModule } from './cart/cart-root.module';
Expand Down Expand Up @@ -49,7 +47,6 @@ import { environment } from '../environments/environment';
ThankYouModule,
TemplateModule,
NotFoundModule,
DaffProgressIndicatorModule,
],
providers: [],
bootstrap: [AppComponent],
Expand Down
12 changes: 6 additions & 6 deletions apps/demo/src/app/routing/indicator/indicator.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
import { RouterTestingModule } from '@angular/router/testing';
import { Subject } from 'rxjs';

import { DaffProgressIndicatorModule } from '@daffodil/design';
import { DaffProgressBarModule } from '@daffodil/design/progress-bar';

import { DemoIndicatorComponent } from './indicator.component';

Expand All @@ -34,7 +34,7 @@ describe('DemoIndicatorComponent', () => {
imports:[
NoopAnimationsModule,
RouterTestingModule,
DaffProgressIndicatorModule,
DaffProgressBarModule,
],
declarations: [
DemoIndicatorComponent,
Expand All @@ -59,24 +59,24 @@ describe('DemoIndicatorComponent', () => {
});

describe('when the router triggers "NavigationStart"', () => {
it('should set show to true and show the `daff-progress-indicator', () => {
it('should set show to true and show the `daff-progress-bar', () => {
router.events.next(new NavigationStart(1, 'mock'));
fixture.detectChanges();

expect(component.routingPercentage).toEqual(0);
expect(component.show).toBe(true);
expect(fixture.debugElement.query(By.css('daff-progress-indicator'))).toBeDefined();
expect(fixture.debugElement.query(By.css('daff-progress-bar'))).toBeDefined();
});
});

describe('when the router triggers "NavigationEnd"', () => {
it('should set show to false and hide the `daff-progress-indicator`', () => {
it('should set show to false and hide the `daff-progress-bar`', () => {
router.events.next(new NavigationEnd(1, 'mock', 'mock'));
fixture.detectChanges();

expect(component.routingPercentage).toEqual(100);
expect(component.show).toBe(false);
expect(fixture.debugElement.query(By.css('daff-progress-indicator'))).toBe(null);
expect(fixture.debugElement.query(By.css('daff-progress-bar'))).toBe(null);
});
});
});
1 change: 0 additions & 1 deletion apps/design-land/src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export const appRoutes: Routes = [
{ path: 'notification', loadChildren: () => import('./notification/notification.module').then(m => m.DesignLandNotificationModule) },
{ path: 'paginator', loadChildren: () => import('./paginator/paginator.module').then(m => m.DesignLandPaginatorModule) },
{ path: 'progress-bar', loadChildren: () => import('./progress-bar/progress-bar.module').then(m => m.DesignLandProgressBarModule) },
{ path: 'progress-indicator', loadChildren: () => import('./progress-indicator/progress-indicator.module').then(m => m.DesignLandProgressIndicatorModule) },
{ path: 'qty-dropdown', loadChildren: () => import('./qty-dropdown/qty-dropdown.module').then(m => m.DesignLandQtyDropdownModule) },
{ path: 'quantity-field', loadChildren: () => import('./quantity-field/quantity-field.module').then(m => m.DesignLandQuantityFieldModule) },
{ path: 'sidebar', loadChildren: () => import('./sidebar/sidebar.module').then(m => m.DesignLandSidebarModule) },
Expand Down
1 change: 0 additions & 1 deletion apps/design-land/src/app/link-set/link-set.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ <h2>Default</h2>
<a daff-link-set-item routerLink="button">Button</a>
<a daff-link-set-item routerLink="link">Link</a>
<a daff-link-set-item routerLink="loading-icon">Loading Icon</a>
<a daff-link-set-item routerLink="progress-indicator">Progress Indicator</a>
</daff-link-set>

<h2>Nested Link Sets</h2>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

7 changes: 0 additions & 7 deletions apps/design-land/src/assets/nav.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,6 @@
"items": [],
"data": {}
},
{
"title": "Progress Indicator (Deprecated)",
"url": "progress-indicator",
"id": "progress-indicator",
"items": [],
"data": {}
},
{
"title": "Radio",
"url": "radio",
Expand Down
1 change: 0 additions & 1 deletion libs/design/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ Refer to the [Upgrade Guide](./guides/upgrading.md).
* [Quantity Field](./src/atoms/form/quantity-field/README.md)
* [Image](./src/atoms/image/README.md)
* [Loading Icon](./src/atoms/loading-icon/README.md)
* [Progress Indicator](./src/atoms/progress-indicator/README.md)

### Molecules
* [Accordion](./src/molecules/accordion/README.md)
Expand Down
2 changes: 0 additions & 2 deletions libs/design/scss/theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
@use '../src/atoms/form/input/input-theme' as input;
@use '../src/atoms/form/native-select/native-select-theme' as native-select;
@use '../loading-icon/src/loading-icon-theme' as loading-icon;
@use '../src/atoms/progress-indicator/progress-indicator-theme' as progress-indicator;
@use '../accordion/src/accordion-theme' as accordion;
@use '../callout/src/callout-theme' as callout;
@use '../card/src/card-theme' as card;
Expand Down Expand Up @@ -66,7 +65,6 @@
@include input.daff-input-theme($theme);
@include native-select.daff-native-select-theme($theme);
@include loading-icon.daff-loading-icon-theme($theme);
@include progress-indicator.daff-progress-indicator-theme($theme);
@include progress-bar.daff-progress-bar-theme($theme);

// Molecules
Expand Down
2 changes: 0 additions & 2 deletions libs/design/src/atoms/progress-indicator/README.md

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 87e6d41

Please sign in to comment.