feat(eslint-config): restore legacy lint rules (#2728)

apps/daffio/src/app/docs/resolvers/docs-resolver.service.ts

@@ -1,5 +1,9 @@
 import { Injectable } from '@angular/core';
-import { ActivatedRouteSnapshot, RouterStateSnapshot, Router } from '@angular/router';
+import {
+  ActivatedRouteSnapshot,
+  RouterStateSnapshot,
+  Router,
+} from '@angular/router';
 import {
   Observable,
   EMPTY,

apps/demo/src/app/app.module.ts

@@ -38,7 +38,7 @@ import { environment } from '../environments/environment';
     StoreDevtoolsModule.instrument({
       maxAge: 25, // Retains last 25 states
       logOnly: environment.production, // Restrict extension to log-only mode
-      connectInZone: true
+      connectInZone: true,
     }),
 
     AppRoutingModule,

apps/demo/src/app/product/components/product-grid/product-grid.component.spec.ts

@@ -46,7 +46,7 @@ describe('ProductGridComponent', () => {
 
     fixture = TestBed.createComponent(WrapperComponent);
     wrapper = fixture.componentInstance;
-    wrapper.productsValue = new Array(productFactory.create(), productFactory.create());
+    wrapper.productsValue = [productFactory.create(), productFactory.create()];
 
     fixture.detectChanges();
 

apps/demo/src/app/routing/router-percent-enum.ts

@@ -8,6 +8,8 @@ export enum RouterPercentEnum {
   ResolveStart = 70,
   ResolveEnd = 80,
   NavigationEnd = 100,
+  // eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
   NavigationCancel = 100,
+  // eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
   NavigationError = 100
 }

libs/analytics-provider-data-layer/.eslintrc.js

@@ -10,8 +10,8 @@ module.exports = {
       ],
       parserOptions: {
         project: [
-          'libs/analytics/tsconfig.lib.json',
-          'libs/analytics/tsconfig.spec.json'
+          'libs/analytics-provider-data-layer/tsconfig.lib.json',
+          'libs/analytics-provider-data-layer/tsconfig.spec.json'
         ],
         createDefaultProgram: true
       },

libs/authorizenet/driver/src/errors/error-codes.enum.ts

@@ -8,7 +8,7 @@ export enum DaffAuthorizeNetDriverErrorCodes {
   AUTH_FAILED = 'DAFF_AUTHORIZE_NET_AUTH_FAILED',
   INPUT_MISSING = 'DAFF_AUTHORIZE_NET_INPUT_MISSING',
   INSECURE_CONNECTION = 'DAFF_AUTHORIZE_NET_INSECURE_CONNECTION',
-  INVALID_API_RESPONSE = 'DAFF_AUTHORIZE_NET_ACCEPTJS_INVALID',
+  INVALID_API_RESPONSE = 'DAFF_AUTHORIZE_NET_INVALID_API_RESPONSE',
   INVALID_CC_CVV = 'DAFF_AUTHORIZE_NET_INVALID_CC_CVV',
   INVALID_CC_EXP_MONTH = 'DAFF_AUTHORIZE_NET_INVALID_CC_EXP_MONTH',
   INVALID_CC_EXP_YEAR = 'DAFF_AUTHORIZE_NET_INVALID_CC_EXP_YEAR',

libs/cart-store-credit/.eslintrc.js

@@ -10,8 +10,8 @@ module.exports = {
       ],
       parserOptions: {
         project: [
-          'libs/cart/tsconfig.lib.json',
-          'libs/cart/tsconfig.spec.json'
+          'libs/cart-store-credit/tsconfig.lib.json',
+          'libs/cart-store-credit/tsconfig.spec.json'
         ],
         createDefaultProgram: true
       },

libs/cart/routing/src/guards/in-stock-items/in-stock-items.guard.ts

@@ -2,7 +2,12 @@ import {
   Injectable,
   Inject,
 } from '@angular/core';
-import { ActivatedRouteSnapshot, Router, RouterStateSnapshot, UrlTree } from '@angular/router';
+import {
+  ActivatedRouteSnapshot,
+  Router,
+  RouterStateSnapshot,
+  UrlTree,
+} from '@angular/router';
 import { Observable } from 'rxjs';
 import {
   tap,

libs/cart/routing/src/guards/resolve-cart/resolve-cart.guard.ts

@@ -2,7 +2,10 @@ import {
   Injectable,
   Inject,
 } from '@angular/core';
-import { Router, UrlTree } from '@angular/router';
+import {
+  Router,
+  UrlTree,
+} from '@angular/router';
 import {
   Observable,
   iif,

libs/cart/routing/src/guards/resolved-cart/resolved-cart.guard.ts

@@ -2,7 +2,10 @@ import {
   Injectable,
   Inject,
 } from '@angular/core';
-import { Router, UrlTree } from '@angular/router';
+import {
+  Router,
+  UrlTree,
+} from '@angular/router';
 import { Observable } from 'rxjs';
 import {
   tap,

libs/category/routing/src/resolvers/category-page-url/category-page-url.resolver.ts

@@ -4,7 +4,10 @@ import {
   Injectable,
   PLATFORM_ID,
 } from '@angular/core';
-import { ActivatedRouteSnapshot, RouterStateSnapshot } from '@angular/router';
+import {
+  ActivatedRouteSnapshot,
+  RouterStateSnapshot,
+} from '@angular/router';
 import { ofType } from '@ngrx/effects';
 import {
   ActionsSubject,

libs/content/driver/magento/testing/src/factories/block.factory.ts

@@ -5,7 +5,7 @@ import { MagentoContentBlock } from '@daffodil/content/driver/magento';
 import { DaffModelFactory } from '@daffodil/core/testing';
 
 export class MockMagentoContentBlock implements MagentoContentBlock {
-  __typename: 'CmsBlock' = 'CmsBlock';
+  __typename = <const>'CmsBlock';
   identifier = faker.datatype.uuid();
   title = faker.random.word();
   content = faker.random.words(5);

libs/core/src/utils/range.ts

@@ -10,5 +10,5 @@
  * @returns number
  */
 export const range = (start: number, end: number): Array<number> =>
-  Array.apply(null, Array(end - start + 1)).map((val, index) => index + start);
+  Array(end - start + 1).fill(0).map((val, index) => index + start);
 

libs/core/state/src/states/state.enum.ts

@@ -54,5 +54,6 @@ export const enum DaffState {
    * @deprecated
    * Use DaffState.Stable instead.
    */
+  // eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
   Complete = 'Stable'
 }

libs/core/testing/src/factories/filters/type/range-numeric/pair.ts

@@ -10,7 +10,7 @@ import { DaffFilterRangeNumericOptionFactory } from './option';
 import { DaffModelFactory } from '../../../factory';
 
 export class MockDaffFilterRangeNumericPair implements DaffFilterRangePair<number> {
-  applied: true = true;
+  applied = <const>true;
   max: DaffFilterRangeOption<number>;
   min: DaffFilterRangeOption<number>;
 }

libs/customer-order/driver/magento/testing/src/factories/order.factory.ts

@@ -15,7 +15,7 @@ import {
 
 export class MockMagentoCustomerOrder implements MagentoCustomerOrder {
   protected _numberOfSuborders = faker.datatype.number({ min: 1, max: 3 });
-  __typename: 'CustomerOrder' = 'CustomerOrder';
+  __typename = <const>'CustomerOrder';
   id = faker.datatype.uuid();
   order_date = faker.date.past().toString();
   status = faker.random.word();

libs/customer-payment-authorizenet/.eslintrc.js

@@ -10,8 +10,8 @@ module.exports = {
       ],
       parserOptions: {
         project: [
-          'libs/customer/tsconfig.lib.json',
-          'libs/customer/tsconfig.spec.json'
+          'libs/customer-payment-authorizenet/tsconfig.lib.json',
+          'libs/customer-payment-authorizenet/tsconfig.spec.json'
         ],
         createDefaultProgram: true
       },

libs/customer-payment-authorizenet/driver/magento/testing/src/factories/token-base-card.factory.ts

@@ -9,7 +9,7 @@ import {
 } from '@daffodil/customer-payment-authorizenet/driver/magento';
 
 export class MockMagentoTokenBaseCard implements MagentoTokenBaseCard {
-  __typename: 'TokenBaseCard' = 'TokenBaseCard';
+  __typename = <const>'TokenBaseCard';
   hash = faker.datatype.uuid();
   address = this.addressFactory.create();
   customer_email = faker.internet.email();

libs/customer-payment/.eslintrc.js

@@ -10,8 +10,8 @@ module.exports = {
       ],
       parserOptions: {
         project: [
-          'libs/customer/tsconfig.lib.json',
-          'libs/customer/tsconfig.spec.json'
+          'libs/customer-payment/tsconfig.lib.json',
+          'libs/customer-payment/tsconfig.spec.json'
         ],
         createDefaultProgram: true
       },

libs/customer-payment/routing/src/resolvers/customer-payments.resolver.ts

@@ -1,5 +1,4 @@
 import { Injectable } from '@angular/core';
-
 import {
   Observable,
   of,

libs/customer-store-credit/.eslintrc.js

@@ -10,8 +10,8 @@ module.exports = {
       ],
       parserOptions: {
         project: [
-          'libs/customer/tsconfig.lib.json',
-          'libs/customer/tsconfig.spec.json'
+          'libs/customer-store-credit/tsconfig.lib.json',
+          'libs/customer-store-credit/tsconfig.spec.json'
         ],
         createDefaultProgram: true
       },

libs/customer-store-credit/driver/magento/testing/src/factories/customer-store-credit.factory.ts

@@ -6,7 +6,7 @@ import { MagentoCustomerStoreCredit } from '@daffodil/customer-store-credit/driv
 import { MagentoMoneyFactory } from '@daffodil/driver/magento/testing';
 
 export class MockMagentoCustomerStoreCredit implements MagentoCustomerStoreCredit {
-  __typename: 'CustomerStoreCredit' = 'CustomerStoreCredit';
+  __typename = <const>'CustomerStoreCredit';
   current_balance = this.moneyFactory.create();
   enabled = faker.datatype.boolean();
 

libs/customer-store-credit/routing/src/resolvers/customer-store-credit.resolver.ts

@@ -1,5 +1,4 @@
 import { Injectable } from '@angular/core';
-
 import {
   Observable,
   of,

libs/customer/driver/magento/testing/src/factories/customer.factory.ts

@@ -10,7 +10,7 @@ import {
 import { MagentoCustomerAddressFactory } from './address.factory';
 
 class MockMagentoCustomer implements MagentoCustomer {
-  __typename: 'Customer' = 'Customer';
+  __typename = <const>'Customer';
   email = faker.internet.email();
   firstname = faker.name.firstName();
   lastname = faker.name.lastName();

libs/customer/routing/src/resolvers/customer.resolver.ts

@@ -1,5 +1,4 @@
 import { Injectable } from '@angular/core';
-
 import {
   Observable,
   of,

libs/design/radio/examples/src/basic-radio/basic-radio.component.ts

@@ -1,7 +1,6 @@
 import {
   ChangeDetectionStrategy,
   Component,
-  OnInit,
 } from '@angular/core';
 import {
   UntypedFormGroup,
@@ -14,14 +13,10 @@ import {
   templateUrl: './basic-radio.component.html',
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class BasicRadioComponent implements OnInit {
-
+export class BasicRadioComponent {
   radioGroup = new UntypedFormGroup({
     race: new UntypedFormControl('Zerg'),
   });
-  constructor() {
-  }
 
-  ngOnInit() {
-  }
+  constructor() {}
 }

libs/design/src/atoms/progress-indicator/progress-indicator.component.ts

@@ -69,7 +69,7 @@ export class DaffProgressIndicatorComponent extends _daffProgressIndicatorBase i
    * @param event: AnimationEvent
    */
   onAnimationComplete(event: AnimationEvent): void {
-    // @ts-ignore: @angular/animations typing error on event.toState as string
+    // @ts-expect-error: @angular/animations typing error on event.toState as string
     // See: https://github.com/angular/angular/issues/26507
     if(event.toState === '100' || event.toState === 100) {
       this.finished.emit();

libs/design/src/molecules/qty-dropdown/qty-dropdown.component.ts

@@ -118,11 +118,9 @@ export class DaffQtyDropdownComponent implements OnInit {
 
   private selectInput() {
     // TODO: readdress this method
-    // why are we binding `this`?
     // why use `setTimeout` instead of angular patterns?
-    const that = this;
     setTimeout(() => {
-      const input = <HTMLInputElement>document.getElementById('input_' + that.id);
+      const input = <HTMLInputElement>document.getElementById('input_' + this.id);
       input?.select();
     });
   }

libs/external-router/routing/src/guard/existence.guard.ts

@@ -4,7 +4,12 @@ import {
   Inject,
   PLATFORM_ID,
 } from '@angular/core';
-import { ActivatedRouteSnapshot, Router, RouterStateSnapshot, UrlTree } from '@angular/router';
+import {
+  ActivatedRouteSnapshot,
+  Router,
+  RouterStateSnapshot,
+  UrlTree,
+} from '@angular/router';
 import {
   Observable,
   of,

libs/order/driver/magento/2-4-1/testing/src/factories/order-address.factory.ts

@@ -5,7 +5,7 @@ import { DaffModelFactory } from '@daffodil/core/testing';
 import { MagentoOrderAddress } from '@daffodil/order/driver/magento/2-4-1';
 
 export class MockOrderAddress implements MagentoOrderAddress {
-  __typename: 'OrderAddress' = 'OrderAddress';
+  __typename = <const>'OrderAddress';
   street = [faker.address.streetName()];
   city = faker.address.city();
   region_id = faker.unique(faker.datatype.number);

libs/order/driver/magento/2-4-1/testing/src/factories/order-credit-item.factory.ts

@@ -7,7 +7,7 @@ import { MagentoOrderCreditItem } from '@daffodil/order/driver/magento/2-4-1';
 import { MagentoOrderItemFactory } from './order-item.factory';
 
 export class MockOrderCreditItem implements MagentoOrderCreditItem {
-  __typename: 'CreditMemoItem' = 'CreditMemoItem';
+  __typename = <const>'CreditMemoItem';
   order_item = this.itemFactory.create();
   quantity_refunded = faker.datatype.number({ min: 1, max: 100 });
 

libs/order/driver/magento/2-4-1/testing/src/factories/order-credit.factory.ts

@@ -8,7 +8,7 @@ import { MagentoOrderCreditItemFactory } from './order-credit-item.factory';
 import { MagentoOrderTotalFactory } from './order-total.factory';
 
 export class MockOrderCredit implements MagentoOrderCredit {
-  __typename: 'CreditMemo' = 'CreditMemo';
+  __typename = <const>'CreditMemo';
   items = this.itemFactory.createMany(faker.datatype.number({ min: 1, max: 3 }));
   total = this.totalFactory.create({
     __typename: 'CreditMemoTotal',

libs/order/driver/magento/2-4-1/testing/src/factories/order-invoice-item.factory.ts

@@ -7,7 +7,7 @@ import { MagentoOrderInvoiceItem } from '@daffodil/order/driver/magento/2-4-1';
 import { MagentoOrderItemFactory } from './order-item.factory';
 
 export class MockOrderInvoiceItem implements MagentoOrderInvoiceItem {
-  __typename: 'InvoiceItem' = 'InvoiceItem';
+  __typename = <const>'InvoiceItem';
   order_item = this.itemFactory.create();
   quantity_invoiced = faker.datatype.number({ min: 1, max: 100 });
 

libs/order/driver/magento/2-4-1/testing/src/factories/order-invoice.factory.ts

@@ -8,7 +8,7 @@ import { MagentoOrderInvoiceItemFactory } from './order-invoice-item.factory';
 import { MagentoOrderTotalFactory } from './order-total.factory';
 
 export class MockOrderInvoice implements MagentoOrderInvoice {
-  __typename: 'Invoice' = 'Invoice';
+  __typename = <const>'Invoice';
   items = this.itemFactory.createMany(faker.datatype.number({ min: 1, max: 3 }));
   total = this.totalFactory.create({
     __typename: 'InvoiceTotal',

libs/order/driver/magento/2-4-1/testing/src/factories/order-payment.factory.ts

@@ -5,7 +5,7 @@ import { DaffModelFactory } from '@daffodil/core/testing';
 import { MagentoOrderPayment } from '@daffodil/order/driver/magento/2-4-1';
 
 export class MockOrderPayment implements MagentoOrderPayment {
-  __typename: 'OrderPaymentMethod' = 'OrderPaymentMethod';
+  __typename = <const>'OrderPaymentMethod';
   name = 'card';
   type = 'visa';
   additional_data = [];

libs/order/driver/magento/2-4-1/testing/src/factories/order-shipment-item.factory.ts

@@ -7,7 +7,7 @@ import { MagentoOrderShipmentItem } from '@daffodil/order/driver/magento/2-4-1';
 import { MagentoOrderItemFactory } from './order-item.factory';
 
 export class MockOrderShipmentItem implements MagentoOrderShipmentItem {
-  __typename: 'ShipmentItem' = 'ShipmentItem';
+  __typename = <const>'ShipmentItem';
   order_item = this.itemFactory.create();
   quantity_shipped = faker.datatype.number({ min: 1, max: 100 });
 

libs/order/driver/magento/2-4-1/testing/src/factories/order-shipment-tracking.factory.ts

@@ -5,7 +5,7 @@ import { DaffModelFactory } from '@daffodil/core/testing';
 import { MagentoOrderShipmentTracking } from '@daffodil/order/driver/magento/2-4-1';
 
 export class MockOrderShipmentTracking implements MagentoOrderShipmentTracking {
-  __typename: 'ShipmentTracking' = 'ShipmentTracking';
+  __typename = <const>'ShipmentTracking';
   number = faker.random.alphaNumeric(16);
   carrier = faker.random.word();
   title = faker.random.word();

libs/order/driver/magento/2-4-1/testing/src/factories/order-shipment.factory.ts

@@ -12,7 +12,7 @@ import { MagentoOrderShipmentItemFactory } from './order-shipment-item.factory';
 import { MagentoOrderShipmentTrackingFactory } from './order-shipment-tracking.factory';
 
 export class MockOrderShipment implements MagentoOrderShipment {
-  __typename: 'OrderShipment' = 'OrderShipment';
+  __typename = <const>'OrderShipment';
   tracking = this.createTracking();
   items = this.createItems();
 

libs/order/driver/magento/2-4-1/testing/src/factories/order.factory.ts

@@ -13,7 +13,7 @@ import { MagentoOrderShipmentFactory } from './order-shipment.factory';
 import { MagentoOrderTotalFactory } from './order-total.factory';
 
 export class MockOrder implements MagentoOrder {
-  __typename: 'GraycoreGuestOrder' = 'GraycoreGuestOrder';
+  __typename = <const>'GraycoreGuestOrder';
   id = faker.datatype.uuid();
   number = faker.datatype.uuid();
   email = faker.internet.email();

libs/paypal/driver/magento/src/constants/method.ts

@@ -1 +1 @@
-export const MAGENTO_PAYPAL_EXPRESS_PAYMENT_METHOD: 'paypal_express' = 'paypal_express';
+export const MAGENTO_PAYPAL_EXPRESS_PAYMENT_METHOD = <const>'paypal_express';