fix(reviews): state errors are not reset upon success (#2577)

graycoreio · Sep 29, 2023 · 9cf5f58 · 9cf5f58
1 parent ec50bcb
commit 9cf5f58
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/libs/reviews/state/src/reducers/product-reviews/reducer.spec.ts b/libs/reviews/state/src/reducers/product-reviews/reducer.spec.ts
@@ -124,6 +124,7 @@ describe('@daffodil/reviews/state | daffProductPageReviewsReducer', () => {
       state = {
         ...daffProductReviewsReducerInitialState,
         loading: true,
+        errors: [{ code: 'firstErrorCode', message: 'firstErrorMessage' }],
       };
 
       const productLoadSuccess = new DaffReviewsProductListSuccess({
@@ -136,6 +137,10 @@ describe('@daffodil/reviews/state | daffProductPageReviewsReducer', () => {
     it('sets loading to false', () => {
       expect(result.loading).toEqual(false);
     });
+
+    it('resets errors', () => {
+      expect(result.errors).toEqual([]);
+    });
   });
 
   describe('when ReviewsProductListFailureAction is triggered', () => {

diff --git a/libs/reviews/state/src/reducers/product-reviews/reducer.ts b/libs/reviews/state/src/reducers/product-reviews/reducer.ts
@@ -34,14 +34,21 @@ export function daffProductPageReviewsReducer<T extends DaffProductReview = Daff
     case DaffProductReviewsCollectionActionTypes.ChangeFilterAction:
     case DaffProductReviewsCollectionActionTypes.ChangeSortingAction:
       return { ...state, loading: true };
+
     case DaffReviewsProductActionTypes.ListSuccessAction:
-      return { ...state, loading: false };
+      return {
+        ...state,
+        loading: false,
+        errors: [],
+      };
+
     case DaffReviewsProductActionTypes.ListFailureAction:
       return {
         ...state,
         loading: false,
         errors: state.errors.concat([action.payload]),
       };
+
     default:
       return state;
   }