Skip to content

Commit

Permalink
feat(cart)!: package prefix reducer initial state exports (#2501)
Browse files Browse the repository at this point in the history 
BREAKING CHANGE: `initialState` -> `daffCartReducerInitialState`
  • Loading branch information
@griest024
griest024 committed Jul 13, 2023
1 parent e280f6f commit c7b85d7
Show file tree
Hide file tree
Showing 27 changed files with 285 additions and 284 deletions.
4 changes: 2 additions & 2 deletions libs/cart-store-credit/state/src/reducers/cart.reducer.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { DaffCartWithStoreCredit } from '@daffodil/cart-store-credit';
import {
DaffCartOperationType,
DaffCartReducerState,
initialState,
daffCartReducerInitialState,
} from '@daffodil/cart/state';
import { DaffState } from '@daffodil/core/state';

Expand All @@ -13,7 +13,7 @@ import {
} from '../actions/public_api';

export function daffCartStoreCreditCartReducer<T extends DaffCartWithStoreCredit = DaffCartWithStoreCredit>(
state = initialState,
state = daffCartReducerInitialState,
action: DaffCartStoreCreditActions,
): DaffCartReducerState<T> {
switch (action.type) {
Expand Down
4 changes: 2 additions & 2 deletions libs/cart/state/src/facades/cart/cart.facade.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
DaffCartItemInputType,
} from '@daffodil/cart';
import {
initialState,
daffCartReducerInitialState,
DaffCartReducersState,
DaffCartLoading,
DaffCartErrors,
Expand Down Expand Up @@ -176,7 +176,7 @@ describe('DaffCartFacade', () => {

describe('cart$', () => {
it('should initially be cart with no defined properties', () => {
const expected = cold('a', { a: initialState.cart });
const expected = cold('a', { a: daffCartReducerInitialState.cart });
expect(facade.cart$).toBeObservable(expected);
});

Expand Down
42 changes: 21 additions & 21 deletions libs/cart/state/src/reducers/cart-billing-address/cart-billing-address.reducer.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
DaffCartAddressUpdate,
DaffCartAddressUpdateSuccess,
DaffCartAddressUpdateFailure,
initialState,
daffCartReducerInitialState,
} from '@daffodil/cart/state';
import { DaffCartFactory } from '@daffodil/cart/testing';
import {
Expand All @@ -35,17 +35,17 @@ describe('Cart | Reducer | Cart Billing Address', () => {
it('should return the current state', () => {
const action = <any>{};

const result = cartBillingAddressReducer(initialState, action);
const result = cartBillingAddressReducer(daffCartReducerInitialState, action);

expect(result).toBe(initialState);
expect(result).toBe(daffCartReducerInitialState);
});
});

describe('when CartBillingAddressLoadAction is triggered', () => {
it('should set loading state to true', () => {
const cartListLoadAction = new DaffCartBillingAddressLoad();

const result = cartBillingAddressReducer(initialState, cartListLoadAction);
const result = cartBillingAddressReducer(daffCartReducerInitialState, cartListLoadAction);

expect(result.loading[DaffCartOperationType.BillingAddress]).toEqual(DaffState.Resolving);
});
Expand All @@ -57,9 +57,9 @@ describe('Cart | Reducer | Cart Billing Address', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.BillingAddress]: DaffState.Resolving,
},
};
Expand Down Expand Up @@ -89,13 +89,13 @@ describe('Cart | Reducer | Cart Billing Address', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.BillingAddress]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.BillingAddress]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand All @@ -118,7 +118,7 @@ describe('Cart | Reducer | Cart Billing Address', () => {
it('should indicate that the cart billing address is being mutated', () => {
const cartBillingAddressUpdateAction = new DaffCartBillingAddressUpdate(cart.billing_address);

const result = cartBillingAddressReducer(initialState, cartBillingAddressUpdateAction);
const result = cartBillingAddressReducer(daffCartReducerInitialState, cartBillingAddressUpdateAction);

expect(result.loading[DaffCartOperationType.BillingAddress]).toEqual(DaffState.Mutating);
});
Expand All @@ -131,9 +131,9 @@ describe('Cart | Reducer | Cart Billing Address', () => {
beforeEach(() => {
const cartBillingAddressUpdateActionSuccess = new DaffCartBillingAddressUpdateSuccess(cart);
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.BillingAddress]: DaffState.Resolving,
},
};
Expand Down Expand Up @@ -161,13 +161,13 @@ describe('Cart | Reducer | Cart Billing Address', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.BillingAddress]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.BillingAddress]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand All @@ -192,7 +192,7 @@ describe('Cart | Reducer | Cart Billing Address', () => {
it('should indicate that the cart billing address is being mutated', () => {
const cartAddressUpdateAction = new DaffCartAddressUpdate(cart.billing_address);

const result = cartBillingAddressReducer(initialState, cartAddressUpdateAction);
const result = cartBillingAddressReducer(daffCartReducerInitialState, cartAddressUpdateAction);

expect(result.loading[DaffCartOperationType.BillingAddress]).toEqual(DaffState.Mutating);
});
Expand All @@ -205,9 +205,9 @@ describe('Cart | Reducer | Cart Billing Address', () => {
beforeEach(() => {
const cartAddressUpdateActionSuccess = new DaffCartAddressUpdateSuccess(cart);
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.BillingAddress]: DaffState.Resolving,
},
};
Expand Down Expand Up @@ -235,13 +235,13 @@ describe('Cart | Reducer | Cart Billing Address', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.BillingAddress]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.BillingAddress]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand Down
4 changes: 2 additions & 2 deletions libs/cart/state/src/reducers/cart-billing-address/cart-billing-address.reducer.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
DaffCartAddressActionTypes,
} from '../../actions/public_api';
import { ActionTypes } from '../action-types.type';
import { initialState } from '../cart-initial-state';
import { daffCartReducerInitialState } from '../cart-initial-state';
import { DaffCartOperationType } from '../cart-operation-type.enum';
import { DaffCartReducerState } from '../cart-state.interface';
import {
Expand All @@ -20,7 +20,7 @@ const resetErrors = initializeErrorResetter(DaffCartOperationType.BillingAddress
const setLoading = initializeLoadingSetter(DaffCartOperationType.BillingAddress);

export function cartBillingAddressReducer<T extends DaffCart>(
state = initialState,
state = daffCartReducerInitialState,
action: ActionTypes,
): DaffCartReducerState<T> {
switch (action.type) {
Expand Down
66 changes: 33 additions & 33 deletions libs/cart/state/src/reducers/cart-coupon/cart-coupon.reducer.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
DaffCartCouponRemoveAll,
DaffCartCouponRemoveAllSuccess,
DaffCartCouponRemoveAllFailure,
initialState,
daffCartReducerInitialState,
DaffCartCouponClearErrors,
} from '@daffodil/cart/state';
import {
Expand Down Expand Up @@ -54,17 +54,17 @@ describe('Cart | Reducer | cartCouponReducer', () => {
it('should return the current state', () => {
const action = <any>{};

const result = reducer(initialState, action);
const result = reducer(daffCartReducerInitialState, action);

expect(result).toEqual(initialState);
expect(result).toEqual(daffCartReducerInitialState);
});
});

describe('when CartCouponApplyAction is triggered', () => {
it('should indicate that the cart coupon is being mutated', () => {
const cartCouponApplyAction: DaffCartCouponApply = new DaffCartCouponApply(mockCoupon);

const result = reducer(initialState, cartCouponApplyAction);
const result = reducer(daffCartReducerInitialState, cartCouponApplyAction);

expect(result.loading[DaffCartOperationType.Coupon]).toEqual(DaffState.Mutating);
});
Expand All @@ -76,9 +76,9 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
};
Expand Down Expand Up @@ -108,13 +108,13 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.Coupon]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand All @@ -137,7 +137,7 @@ describe('Cart | Reducer | cartCouponReducer', () => {
it('should set loading state to true', () => {
const cartCouponListAction: DaffCartCouponList = new DaffCartCouponList();

const result = reducer(initialState, cartCouponListAction);
const result = reducer(daffCartReducerInitialState, cartCouponListAction);

expect(result.loading[DaffCartOperationType.Coupon]).toEqual(DaffState.Resolving);
});
Expand All @@ -149,9 +149,9 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
};
Expand Down Expand Up @@ -181,13 +181,13 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.Coupon]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand All @@ -210,7 +210,7 @@ describe('Cart | Reducer | cartCouponReducer', () => {
it('should indicate that the cart coupon is being mutated', () => {
const cartCouponRemoveAction: DaffCartCouponRemove = new DaffCartCouponRemove(mockCoupon);

const result = reducer(initialState, cartCouponRemoveAction);
const result = reducer(daffCartReducerInitialState, cartCouponRemoveAction);

expect(result.loading[DaffCartOperationType.Coupon]).toEqual(DaffState.Mutating);
});
Expand All @@ -223,9 +223,9 @@ describe('Cart | Reducer | cartCouponReducer', () => {
beforeEach(() => {
const cartCouponRemoveActionSuccess: DaffCartCouponRemoveSuccess = new DaffCartCouponRemoveSuccess(cart);
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
};
Expand Down Expand Up @@ -253,13 +253,13 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.Coupon]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand All @@ -283,14 +283,14 @@ describe('Cart | Reducer | cartCouponReducer', () => {
describe('when CartCouponRemoveAllAction is triggered', () => {
it('should indicate that the cart coupon is being mutated', () => {
const expectedState: DaffCartReducerState<DaffCart> = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Mutating,
},
};
const cartClear = new DaffCartCouponRemoveAll();
const result = reducer(initialState, cartClear);
const result = reducer(daffCartReducerInitialState, cartClear);

expect(result).toEqual(expectedState);
});
Expand All @@ -301,19 +301,19 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
const cartClearSuccess = new DaffCartCouponRemoveAllSuccess(cart);
result = reducer(initialState, cartClearSuccess);
result = reducer(daffCartReducerInitialState, cartClearSuccess);
});

it('should set the cart payload on state', () => {
const expectedState = {
...initialState,
...daffCartReducerInitialState,
cart: {
...initialState.cart,
...daffCartReducerInitialState.cart,
items: [],
...cart,
},
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Complete,
},
};
Expand All @@ -333,13 +333,13 @@ describe('Cart | Reducer | cartCouponReducer', () => {

beforeEach(() => {
state = {
...initialState,
...daffCartReducerInitialState,
loading: {
...initialState.loading,
...daffCartReducerInitialState.loading,
[DaffCartOperationType.Coupon]: DaffState.Resolving,
},
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.Coupon]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand Down Expand Up @@ -367,9 +367,9 @@ describe('Cart | Reducer | cartCouponReducer', () => {
beforeEach(() => {
const cartCouponRemoveActionSuccess = new DaffCartCouponClearErrors();
state = {
...initialState,
...daffCartReducerInitialState,
errors: {
...initialState.errors,
...daffCartReducerInitialState.errors,
[DaffCartOperationType.Coupon]: [{ code: 'first error code', message: 'first error message' }],
},
};
Expand Down
Loading

0 comments on commit c7b85d7

Please sign in to comment.