Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Indicator/Bar updates #2510

Merged
merged 10 commits into from
May 14, 2024
Merged

Progress Indicator/Bar updates #2510

merged 10 commits into from
May 14, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jul 18, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Progress indicator styles aren't actually working. The naming is not aligned with the aria role. It automatically animates on render.

Fixes: #639
Part of: #1340

What is the new behavior?

  1. Rename DaffProgressIndicatorComponent to DaffProgressBarComponent. Added deprecation notice for progress indicator.
  2. Update styles so that the fill bar is showing up correctly.
  3. Update animation to use transform (GPU friendly) instead of width.
  4. Fix progress bar automatically animating on render.
  5. Update usage in demo from progress indicator to progress bar

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added package: design @daffodil/design status: awaiting review This PR is awaiting review labels Jul 18, 2023
@xelaint xelaint requested review from a team as code owners July 18, 2023 17:06
@xelaint xelaint self-assigned this Jul 18, 2023
@xelaint xelaint assigned damienwebdev and xelaint and unassigned xelaint Jan 3, 2024
@xelaint xelaint removed their assignment Jan 12, 2024
@xelaint xelaint force-pushed the progress-bar branch 2 times, most recently from 4445622 to 9d20185 Compare January 24, 2024 02:40
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit bbc3904 into develop May 14, 2024
13 checks passed
@damienwebdev damienwebdev deleted the progress-bar branch May 14, 2024 12:18
@gray-bot gray-bot mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Progress indicator should not immediately animate on render.
2 participants