Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all)!: move error matcher tokens to state subpackage #2645

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2308

Does this PR introduce a breaking change?

[x] Yes
[ ] No

import error matcher tokens from repsective state subpackages

Other information

@griest024 griest024 added 🚨 breaking changes This PR or issue will cause a breaking change status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Dec 11, 2023
@griest024 griest024 self-assigned this Dec 11, 2023
@griest024 griest024 requested a review from a team as a code owner December 11, 2023 15:34
…raycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…ackage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…raycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…package (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
… subpackage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…ge (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…ge (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…bpackage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…subpackage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…ken to state subpackage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…tate subpackage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…age (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…kage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…kage (graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…raycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
…graycoreio#2645)

BREAKING CHANGE: error matcher injection token has moved to state subpackage
@griest024 griest024 force-pushed the feat/all/move-error-matcher-token branch from 9278f77 to 8be4957 Compare December 11, 2023 15:47
@griest024 griest024 merged commit 8be4957 into graycoreio:develop Dec 11, 2023
39 checks passed
@griest024 griest024 deleted the feat/all/move-error-matcher-token branch December 11, 2023 16:06
@gray-bot gray-bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error matchers in root subpackage introduce a dep on @daffodil/core/state
2 participants