Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add skeletonable public api to design core's public api #2648

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Design core only exposes the DaffSkeletonable interface to the public. daffSkeletonableMixin is not usable by the public.
Fixes: N/A

What is the new behavior?

Update design core's public_api to export the skeletonable public_api instead of only the DaffSkeletonable interface.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Dec 12, 2023
@xelaint xelaint requested a review from a team as a code owner December 12, 2023 01:44
@xelaint xelaint changed the title feat(design): expose skeletonable public_api to design core's public_api feat(design): add skeletonable public api to design core's public api Dec 12, 2023
@xelaint xelaint merged commit 4e0baf9 into develop Dec 12, 2023
13 checks passed
@gray-bot gray-bot mentioned this pull request Dec 12, 2023
@xelaint xelaint deleted the skeletonable-public branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant