Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add DaffSizeable to design core's public api #2653

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 13, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DaffSizeable is not exposed to @daffodil/designs public api. This means the interface is not usable outside of the main design package.

Fixes: N/A

What is the new behavior?

DaffSizeable interface, types, and enums is now part of design's core public api.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Dec 13, 2023
@xelaint xelaint self-assigned this Dec 13, 2023
@xelaint xelaint requested a review from a team as a code owner December 13, 2023 15:57
@xelaint xelaint merged commit 776faa3 into develop Dec 13, 2023
13 checks passed
@gray-bot gray-bot mentioned this pull request Dec 13, 2023
@xelaint xelaint deleted the sizable-interface-public branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant