Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: shard loading icon component #2668

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 18, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DaffLoadingIconComponent is a component within the @daffodil/design package. It rebuilds every time a specific component needs to get rebuilt, which means increase bundle size and build time.

Part of: #1340

What is the new behavior?

Move DaffLoadingIconComponent out of design to help reduce bundle size.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Dec 18, 2023
@xelaint xelaint added this to the Daffodil v1.0 milestone Dec 18, 2023
@xelaint xelaint self-assigned this Dec 18, 2023
@xelaint xelaint requested review from a team as code owners December 18, 2023 22:14
@xelaint xelaint merged commit 7434000 into develop Dec 18, 2023
13 checks passed
@gray-bot gray-bot mentioned this pull request Dec 18, 2023
@xelaint xelaint deleted the shard-loading-icon-component branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant