feat(design)!: move DaffBackdropModule
into DaffSidebarModule
#2673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
DaffBackdropModule
is its own component. It would not be used anywhere else, so it should be part of sidebar. I believe it was originally moved out of sidebar because we thought we'd use it in modal, but we've built modal to use cdkOverlay` instead.Fixes: #2566
What is the new behavior?
Backdrop logic is now part of the
DaffSidebarModule
.DaffBackdropModule
is removed from the design library.Does this PR introduce a breaking change?
Other information