Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: move DaffBackdropModule into DaffSidebarModule #2673

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Dec 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DaffBackdropModule is its own component. It would not be used anywhere else, so it should be part of sidebar. I believe it was originally moved out of sidebar because we thought we'd use it in modal, but we've built modal to use cdkOverlay` instead.

Fixes: #2566

What is the new behavior?

Backdrop logic is now part of the DaffSidebarModule. DaffBackdropModule is removed from the design library.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Dec 19, 2023
@xelaint xelaint added this to the Daffodil v1.0 milestone Dec 19, 2023
@xelaint xelaint self-assigned this Dec 19, 2023
@xelaint xelaint requested a review from a team as a code owner December 19, 2023 22:38
@xelaint xelaint changed the title feat(design)!: move DaffBackdropModule into DaffSidebarModule` feat(design)!: move DaffBackdropModule into DaffSidebarModule Dec 19, 2023
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Dec 20, 2023
@damienwebdev damienwebdev self-assigned this Jan 3, 2024
@xelaint xelaint removed their assignment Jan 12, 2024
@xelaint xelaint merged commit 01db447 into develop Apr 3, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Apr 3, 2024
@damienwebdev damienwebdev deleted the move-backdrop-into-sidebar branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
Development

Successfully merging this pull request may close these issues.

[FEAT] Deprecate DaffBackdropComponent and move logic inside of DaffSidebarComponent
2 participants