Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add injection token factories #2687

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Dec 26, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Adds factories for single and multi tokens. This removes the need to write boilerplate code when creating injection tokens and provider functions.

fixes #2704

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

lays groundwork for #1650

@griest024 griest024 added package: core @daffodil/core status: awaiting review This PR is awaiting review labels Dec 26, 2023
@griest024 griest024 requested a review from a team as a code owner December 26, 2023 18:51
@griest024 griest024 marked this pull request as draft December 26, 2023 23:07
@griest024 griest024 marked this pull request as ready for review January 3, 2024 18:57
@griest024 griest024 assigned damienwebdev and unassigned griest024 Jan 3, 2024
@griest024 griest024 merged commit 8531484 into graycoreio:develop Feb 23, 2024
50 checks passed
@gray-bot gray-bot mentioned this pull request Feb 23, 2024
@griest024 griest024 deleted the feat/core/token-factory branch February 23, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @daffodil/core status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Create injection token/provider factories
2 participants