Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): set sidebar header action's position to absolute #2702

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The sidebar header action is missing a position style. It causes the sidebar height to be much more than intended, especially when using it with the <button daff-icon-button>

Fixes: N/A

What is the new behavior?

Add position: absolute; to sidebar header's action style.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jan 2, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 2, 2024
@xelaint xelaint self-assigned this Jan 2, 2024
@xelaint xelaint requested a review from a team as a code owner January 2, 2024 20:56
@xelaint xelaint merged commit 8eb5c67 into develop Jan 2, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jan 2, 2024
@damienwebdev damienwebdev deleted the update-sidebar-header-style branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant