Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): clean up card styles #2720

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat(design): clean up card styles #2720

merged 1 commit into from
Jan 16, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Title size is too large. Title always has bottom margin even if there's no content.

Fixes: N/A

What is the new behavior?

Reduce title size. Add top margin to content only if it's used with title.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jan 16, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 16, 2024
@xelaint xelaint self-assigned this Jan 16, 2024
@xelaint xelaint requested a review from a team as a code owner January 16, 2024 00:39
@xelaint xelaint merged commit 8399a1b into develop Jan 16, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jan 16, 2024
@xelaint xelaint deleted the clean-up-card-styles branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant