Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): add packages overview page #2721

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There isn't a page that lists out all the available Daffodil packages and a short description of what each package does.

Part of: #2682
Dependent on #2716

What is the new behavior?

Package overview page that shows a brief summary about every Daffodil package.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added package: design @daffodil/design status: blocked This PR or issue is blocked and cannot currently be progressed labels Jan 16, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 16, 2024
@xelaint xelaint requested review from a team as code owners January 16, 2024 01:08
@xelaint xelaint changed the title Packages landing page feat(daffio): add packages overview page Jan 16, 2024
@xelaint xelaint added status: awaiting review This PR is awaiting review and removed status: blocked This PR or issue is blocked and cannot currently be progressed labels Jan 16, 2024
@xelaint xelaint assigned damienwebdev and unassigned damienwebdev Jan 16, 2024
@xelaint xelaint added status: blocked This PR or issue is blocked and cannot currently be progressed and removed status: awaiting review This PR is awaiting review labels Jan 16, 2024
Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the packages (the ones that appear as dropdowns in sidebar) do not get the path transformed correctly since its missing in the root object.

@griest024 griest024 added status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin and removed status: blocked This PR or issue is blocked and cannot currently be progressed labels Jan 24, 2024
griest024
griest024 previously approved these changes Jan 24, 2024
@griest024 griest024 merged commit 10c1b79 into develop Jan 24, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Jan 24, 2024
@xelaint xelaint deleted the packages-landing-page branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants