Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: rename DaffSizeable interface to DaffSizable #2730

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DaffSizeable is the incorrect spelling.

Fixes: #1571

What is the new behavior?

Update interface name to DaffSizable

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jan 18, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 18, 2024
@xelaint xelaint self-assigned this Jan 18, 2024
@xelaint xelaint requested a review from a team as a code owner January 18, 2024 21:10
@xelaint xelaint merged commit ab3b70a into develop Jan 18, 2024
12 of 13 checks passed
@gray-bot gray-bot mentioned this pull request Jan 18, 2024
@xelaint xelaint deleted the sizable-interface-update branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[OTHER] Update DaffSizeable interface name to DaffSizable
1 participant