Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): update api list item background color to animate via opacity #2734

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 19, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

An api list item has a background hover style that is being animated through transitions. Background is not a property in the GPU and animating it causes slower performance.

Part of: #2446

What is the new behavior?

Add the background hover color via the after pseudo-selector and animate it via the opacity property.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: daff.io @daffodil/daff.io label Jan 19, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 19, 2024
@xelaint xelaint self-assigned this Jan 19, 2024
@xelaint xelaint requested review from a team as code owners January 19, 2024 20:16
@xelaint xelaint changed the title feat(daffio): update api list item background color to animate via op… feat(daffio): update api list item background color to animate via opacity Jan 19, 2024
@xelaint xelaint merged commit faacca5 into develop Jan 19, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Jan 19, 2024
@xelaint xelaint deleted the api-list-gpu-animation branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant