Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): update /guides path to /packages #2738

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current path for packages is /guides. This is inaccurate as /guides should be reserved for the actual guides documentation. Packages documentation should be filed under /packages and /packages/..

Part of: #2682

What is the new behavior?

Updated the names of components related to packages to reflect that. Updated the /guides paths to /packages

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added docs This issue is related to documentation package: daff.io @daffodil/daff.io labels Jan 29, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 29, 2024
@xelaint
Copy link
Member Author

xelaint commented Jan 29, 2024

@griest024 which docs files do I need to update to actually change the generated urls for packages to /packages/.. (i.e. /packages/cart). It's currently still /guides since I'm not sure which ones to edit.

@xelaint xelaint added the status: wip This PR is WIP. It should be marked as a draft. label Jan 29, 2024
@griest024
Copy link
Member

@xelaint should just be this one, LMK if thats not sufficient

@xelaint
Copy link
Member Author

xelaint commented Jan 29, 2024

@xelaint should just be this one, LMK if thats not sufficient

@griest024 just changing that line doesn't work. The package cards end up being empty.

@griest024
Copy link
Member

@xelaint I'll take a look

@griest024
Copy link
Member

@xelaint I pushed a change, LMK how this works for you

@xelaint xelaint marked this pull request as ready for review January 30, 2024 01:33
@xelaint xelaint requested review from a team as code owners January 30, 2024 01:33
@xelaint
Copy link
Member Author

xelaint commented Jan 30, 2024

@griest024 ready for review

@xelaint xelaint removed their assignment Jan 30, 2024
@griest024 griest024 added status: awaiting review This PR is awaiting review and removed status: wip This PR is WIP. It should be marked as a draft. labels Jan 30, 2024
@griest024 griest024 added status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin and removed status: awaiting review This PR is awaiting review labels Jan 30, 2024
@xelaint xelaint merged commit 18565d2 into develop Jan 30, 2024
10 checks passed
@gray-bot gray-bot mentioned this pull request Jan 30, 2024
@xelaint xelaint deleted the update-guides-route-to-packages branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is related to documentation package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants