Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add code block style to article headings #2766

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Feb 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Code blocks in article headings are not correctly sized.

Fixes: #2742

What is the new behavior?

Add style to headings so that code blocks are sized in proportion to the heading sizes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Feb 29, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Feb 29, 2024
@xelaint xelaint self-assigned this Feb 29, 2024
@xelaint xelaint requested a review from a team as a code owner February 29, 2024 14:55
@xelaint xelaint changed the title feat(design): update code block style to article headings feat(design): add code block style to article headings Feb 29, 2024
@xelaint xelaint merged commit 377c983 into develop Feb 29, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Feb 29, 2024
@xelaint xelaint deleted the article-heading-code-style branch March 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Code blocks in article headings are not sized correctly
1 participant