Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): update toast docs and import paths in specs #2770

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Mar 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

One of the table headers in docs is using the wrong tag. DaffToast is being imported from @daffodil/design/toast in the specs instead of using relative path.

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint requested a review from a team as a code owner March 20, 2024 14:50
@xelaint xelaint added the package: design @daffodil/design label Mar 20, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Mar 20, 2024
@xelaint xelaint merged commit 9b7cbeb into develop Mar 20, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Mar 6, 2024
@damienwebdev damienwebdev deleted the toast-docs-update branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant