Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add immutable tree transform #2776

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we only have daffTransformTreeInPlace which does pre-order, right-to-left, in-place transformation. This isn't always pleasant to work with and often causes side-effects.

Fixes: N/A

What is the new behavior?

There is a new daffTransformTree which is immutable and pre-order, left-to-right, which is likely more expected.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@damienwebdev damienwebdev merged commit d2ce4fd into develop Apr 29, 2024
13 checks passed
@damienwebdev damienwebdev deleted the tree_immutable_transform branch April 29, 2024 13:03
@gray-bot gray-bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants