Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): remove overflow style on body on destroy in sidebar component #2779

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Apr 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

If user navigates to a page without a sidebar through a link inside an open sidebar, the overflow: hidden; style on the body does not get removed.

Fixes: N/A

What is the new behavior?

Add on destroy to remove overflow code from body

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Apr 30, 2024
@xelaint xelaint requested a review from a team as a code owner April 30, 2024 15:29
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit cadc240 into develop Apr 30, 2024
13 checks passed
@damienwebdev damienwebdev deleted the sidebar-overflow-fix branch April 30, 2024 16:13
@gray-bot gray-bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants