Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add error to DaffState #2781

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Adds an error state to DaffState. While we initially decided that this was redundant beacuse an app dev can check the daffErrors property to determine if the state is an error, the DX of this actually sucks. For example, consider binding the status of a toast to the state of an entity. Without this, it requires all sorts of unnecessary code and logic.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: core @daffodil/core layer: state This PR or issue is related to the redux state layer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels May 13, 2024
@griest024 griest024 self-assigned this May 13, 2024
@griest024 griest024 requested a review from a team as a code owner May 13, 2024 16:50
@griest024 griest024 merged commit bb715eb into graycoreio:develop May 13, 2024
50 checks passed
@griest024 griest024 deleted the feat/core/add-error-to-state branch May 13, 2024 18:48
@gray-bot gray-bot mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: core @daffodil/core status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant