Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): extract cart payment processor effect to reusable function #2790

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Extracts the payment processor effect behavior out for app use (to support injectable actions). Most effects will not be extracted but this one should be considering how much non-standard logic is in it.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: cart @daffodil/cart layer: state This PR or issue is related to the redux state layer status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels May 13, 2024
@griest024 griest024 self-assigned this May 13, 2024
@griest024 griest024 force-pushed the feat/cart/state/extract-payment-processor branch from 830ca25 to d7aa6f4 Compare May 14, 2024 03:57
@griest024 griest024 marked this pull request as ready for review May 14, 2024 03:58
@griest024 griest024 requested a review from a team as a code owner May 14, 2024 03:58
@griest024 griest024 merged commit 0e654a2 into graycoreio:develop May 14, 2024
20 checks passed
@griest024 griest024 deleted the feat/cart/state/extract-payment-processor branch May 14, 2024 04:13
@gray-bot gray-bot mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: state This PR or issue is related to the redux state layer package: cart @daffodil/cart status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant