Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): update modal API so that the modal service can be used to close a modal with the ESC key #2812

Merged
merged 2 commits into from
May 29, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented May 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The modal is not closable via the ESC key.

Fixes:

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Breaking change: The return type of open and the argument type of close have changed. It now returns DaffModalComponent instead of DaffModal.

Other information

@xelaint xelaint added the package: design @daffodil/design label May 23, 2024
@xelaint xelaint requested a review from a team as a code owner May 23, 2024 22:30
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit e121d40 into develop May 29, 2024
13 checks passed
@damienwebdev damienwebdev deleted the modal-esc branch May 29, 2024 16:09
@gray-bot gray-bot mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants