Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat((design-land): update they way open is set for the design land sidebar #2837

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The design land sidebar would automatically open when viewport changes to tablet or mobile.

Fixes: #2836

What is the new behavior?

Design land sidebar remains hidden when viewport changes to tablet or mobile unless user clicks on the hamburger icon to open it.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint requested a review from a team as a code owner June 7, 2024 17:19
@xelaint xelaint merged commit 91738c4 into develop Jun 7, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Jun 7, 2024
@damienwebdev damienwebdev deleted the design-land-sidebar branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Design Land sidebar opens automatically when screen size changes
1 participant