Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: rename notification's dismissable property to dismissible #2844

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

input name is dismissable but that's not the preferred way of spelling.

Fixes: N/A

What is the new behavior?

Rename dismissable property to dismissible

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jun 12, 2024
@xelaint xelaint requested a review from a team as a code owner June 12, 2024 20:20
@xelaint xelaint merged commit ecd0db5 into develop Jun 13, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 13, 2024
@damienwebdev damienwebdev deleted the notification-input-update branch June 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant