Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add id property to quantity field to be passed into quantity select and quantity input #2859

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

I can't set an id on the quantity field.

Fixes: #2858

What is the new behavior?

Add id property and pass it to quantity select and quantity input.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jun 13, 2024
@xelaint xelaint requested a review from a team as a code owner June 13, 2024 19:32
@xelaint xelaint merged commit 2a18308 into develop Jun 13, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] id property on DaffQuantityFieldComponent
1 participant