Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: remove deprecated DaffFeatureComponent from @daffodil/design #2860

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DaffFeatureComponent is still in the codebase even though it's deprecated and not in use anywhere.

Part of: #2852

What is the new behavior?

DaffFeatureComponent is no longer in the code base.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Use DaffCardComponent instead.

Other information

@xelaint xelaint requested review from a team as code owners June 13, 2024 20:25
@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change and removed feat a new feature, enhancement, or improvement labels Jun 13, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 13, 2024
@xelaint xelaint changed the title feat(design): remove deprecated feature component from @daffodil/design feat(design)!: remove deprecated feature component from @daffodil/design Jun 13, 2024
@xelaint xelaint changed the title feat(design)!: remove deprecated feature component from @daffodil/design feat(design)!: remove deprecated DaffFeatureComponent from @daffodil/design Jun 13, 2024
@xelaint xelaint merged commit 26f13a5 into develop Jun 13, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant