Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: remove deprecated properties and directives in DaffAccordionComponent and update usage #2868

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • daffAccordionItemContent is deprecated.
  • initiallyActive is deprecated.

Part of: #2853

What is the new behavior?

  • No longer need to set the directive in order for the content of an accordion item to be placed correctly. Removed all instances of daffAccordionItemContent in usages.
  • Updated usages of initiallyActive to initiallyExpanded

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jun 14, 2024
@xelaint xelaint requested review from a team as code owners June 14, 2024 16:20
@xelaint xelaint changed the title feat(design): remove deprecated properties and components in DaffAcco… feat(design)!: remove deprecated properties and components in DaffAccordionComponent and update usage Jun 14, 2024
@xelaint xelaint changed the title feat(design)!: remove deprecated properties and components in DaffAccordionComponent and update usage feat(design)!: remove deprecated properties and directives in DaffAccordionComponent and update usage Jun 14, 2024
@xelaint xelaint merged commit 198d326 into develop Jun 14, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant