Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): remove all deprecated scss files and mixins in @daffodil/design #2875

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There are deprecated files and mixins in /scss
Fixes: #2853

What is the new behavior?

Removed all deprecated files and mixins.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE:

  • uppercase() mixin has been removed from the codebase. Set the text-transform style directly using scss.
  • single-line-ellipsis() mixin has been removed from the codebase. Use text-truncate() instead.
  • @daffodil/design/scss/daff-util has been replaced with @daffodil/design/scss/utilities
  • daff-tyopgraphy.scss has been replaced with the typography folder.
  • @daffodil/design/scss/daff-global has been replaced with @daffodil/design/scss/global

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jun 14, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 14, 2024
@xelaint xelaint requested review from a team as code owners June 14, 2024 19:14
@xelaint xelaint merged commit 10bd1e9 into develop Jun 20, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Remove all deprecated properties in @daffodil/design components
1 participant