Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): remove DaffArticleTitleDirective and DaffArticleLeadDirective and set styles directly on <h1> and first <p> of an article #2887

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

You must use daffArticleTitle and daffArticleLead selectors in order to apply title and lead styles to an article.

Fixes: #2848

What is the new behavior?

Remove the directives and update styles to be applied to the <h1> of a <daff-article> and the first <p> that comes after a <h1>

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE:

DaffArticleTitleDirective and DaffArticleLeadDirective have been removed. The styles from these directives will automatically apply to the <h1> and first <p> that comes after a <h1> in a <daff-article>.

Other information

…ective and set styles directly on <h1> and first <p> of an article
@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jun 20, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 20, 2024
@xelaint xelaint requested a review from a team as a code owner June 20, 2024 21:54
@xelaint xelaint merged commit 223b304 into develop Jun 21, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
1 participant