Add performance note to SurvivalPredictionStrategy.h #1350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a note for future consideration: one reason Causal Survival Forest can be time consuming on large data is fitting (predicting) survival and censoring curves.
A big time chunk is spent in predicting the survival curves via the DefaultPredictionStrategy. We were aware of this when making it, just documenting it here in case we wish to revisit it in the future, it would be possible to speed up CSF by
(#652)