Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance note to SurvivalPredictionStrategy.h #1350

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Conversation

erikcs
Copy link
Member

@erikcs erikcs commented Sep 9, 2023

Adding a note for future consideration: one reason Causal Survival Forest can be time consuming on large data is fitting (predicting) survival and censoring curves.

A big time chunk is spent in predicting the survival curves via the DefaultPredictionStrategy. We were aware of this when making it, just documenting it here in case we wish to revisit it in the future, it would be possible to speed up CSF by

  • having survival forest use OptimizedPredictionStrategy at a higher memory cost
  • have survival forest use some hash table other than the std library that is optimized for dense data

(#652)

@erikcs erikcs added the performance Issue relates to the speed, memory usage, or scaling aspects of the package. label Sep 9, 2023
@erikcs erikcs merged commit dcbcc7d into master Sep 9, 2023
0 of 7 checks passed
@erikcs erikcs deleted the erikcs-patch-1 branch September 9, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issue relates to the speed, memory usage, or scaling aspects of the package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant