Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hiding Mocks Tests #3331

Merged
merged 6 commits into from
Aug 11, 2024
Merged

chore: Hiding Mocks Tests #3331

merged 6 commits into from
Aug 11, 2024

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Aug 9, 2024

Description

Hides tests requiring mockery behind a build flag.

This makes it easier to lint and test locally without having to install additional tooling.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated getproviders.

levkohimins
levkohimins previously approved these changes Aug 9, 2024
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.circleci/config.yml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 10, 2024

@yhakbar yhakbar enabled auto-merge (squash) August 11, 2024 00:13
@yhakbar yhakbar merged commit 1fc1b03 into master Aug 11, 2024
4 checks passed
@yhakbar yhakbar deleted the chore/hiding-mocks-tests branch August 11, 2024 08:52
akrantz01 pushed a commit to akrantz01/homelab that referenced this pull request Aug 13, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt)
| patch | `v0.66.3` -> `v0.66.5` |
|
[gruntwork-io/terragrunt](https://github.com/gruntwork-io/terragrunt)
| patch | `0.66.3` -> `0.66.5` |

---

### Release Notes

<details>
<summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary>

###
[`v0.66.5`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.66.5)

[Compare
Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.4...v0.66.5)

#### What's Changed

- chore: Adding `bugs` Lint Preset by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3334
- chore: Adding `performance` Lint Preset by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3336

**Full Changelog**:
gruntwork-io/terragrunt@v0.66.4...v0.66.5

###
[`v0.66.4`](https://github.com/gruntwork-io/terragrunt/releases/tag/v0.66.4)

[Compare
Source](https://github.com/gruntwork-io/terragrunt/compare/v0.66.3...v0.66.4)

#### What's Changed

- feat: Add stale issue workflow by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3329
- feat: Add configuration options for AWS S3 server access logging by
[@&#8203;findmyname666](https://github.com/findmyname666) in
[gruntwork-io/terragrunt#3006
- fix: Fixing command not found error by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3330
- fix: Fixing stale action by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3332
- fix: Fix CICD tests for mocks by
[@&#8203;denis256](https://github.com/denis256) in
[gruntwork-io/terragrunt#3335
- chore: Bumping `golangci-lint` to `v1.59.1` by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3333
- chore: Hiding Mocks Tests by
[@&#8203;yhakbar](https://github.com/yhakbar) in
[gruntwork-io/terragrunt#3331

#### New Contributors

- [@&#8203;findmyname666](https://github.com/findmyname666) made their
first contribution in
[gruntwork-io/terragrunt#3006

**Full Changelog**:
gruntwork-io/terragrunt@v0.66.3...v0.66.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/akrantz01/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants